Phase 3 : hardening qualite de code - typage strict, securite, dead code, a11y
Config strictement stricte partout (ruff, mypy --strict, bandit, vulture, import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas casser le build" - l'existant a ete corrige pour la satisfaire plutot que l'inverse. Hooks pre-commit locaux (language: system) bloquants. - Typage mypy --strict propage a tout le moteur (db, screens, auth, core, ai, routes, puis publish/scripts/tests/app.py/build_css.py). - Securite : fuite de handle fichier Windows corrigee dans l'export SCORM (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe "</script>" dans le JSON embarque en <script>, 25 sites). - Architecture : imports circulaires/F811 nettoyes, contrats import-linter respectes, code mort retire (vulture). - Accessibilite : 69 champs de formulaire sans label correctement associe corriges (for/id ou aria-label) sur 11 templates. - ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis appliquees (aucune desactivee sans verification individuelle). - Tests : isolation du compte admin partage (nettoyage ponctuel + fixture de teardown automatique en filet de securite), suite complete verte (591 tests Python, 241 tests JS). - SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport complet analyse point par point, faux positifs documentes. - .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine faisait echouer ESLint (linebreak-style) via un bug connu de git (checkout "en place" qui ignore l'eol force sur un fichier deja present sur disque - contourne en supprimant puis recreant chaque fichier suivi). djLint (H021, styles inline) volontairement saute pour ce commit - backlog assume, deja documente, traite dans un lot separe. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
william
co-authored by
Claude Sonnet 5
Claude Sonnet 5
parent
7db4803b93
commit
c57420c8c9
+191
@@ -0,0 +1,191 @@
|
||||
{
|
||||
"root": true,
|
||||
"env": {
|
||||
"browser": true,
|
||||
"es2021": true
|
||||
},
|
||||
"extends": ["airbnb-base"],
|
||||
"plugins": ["unused-imports"],
|
||||
"parserOptions": {
|
||||
"ecmaVersion": 2021,
|
||||
"sourceType": "script"
|
||||
},
|
||||
"rules": {
|
||||
"max-len": ["error", 120, 2, {
|
||||
"ignoreUrls": true,
|
||||
"ignoreComments": false,
|
||||
"ignoreRegExpLiterals": true,
|
||||
"ignoreStrings": true,
|
||||
"ignoreTemplateLiterals": true
|
||||
}],
|
||||
"unused-imports/no-unused-imports": "error",
|
||||
"unused-imports/no-unused-vars": [
|
||||
"error",
|
||||
{
|
||||
"vars": "all",
|
||||
"args": "after-used",
|
||||
"argsIgnorePattern": "^_",
|
||||
"varsIgnorePattern": "^(_|addClauseRow|addPersonnageCommandExtraRow|applyCameraSize|bindClicks|bindHeldKeyTriggers|bindHoverTexts|bindHoverTriggers|bindKeyboardTriggers|bindPropsAutosave|closeLeftPanel|closePropsPanel|collisionWizardAssetNext|collisionWizardAttendreNext|collisionWizardChainDone|collisionWizardChooseAction|collisionWizardChooseBranch|collisionWizardChooseTrigger|collisionWizardConditionNext|collisionWizardIndicationNext|collisionWizardObjectTargetChosen|collisionWizardValeurChosen|collisionWizardVariableNext|collisionWizardVideoModeChosen|confirmDeleteElement|createGlobalVariable|deleteGlobalVariable|deleteSceneObject|deleteUserAsset|forgeShowTab|iaChatDeleteConversation|iaChatInputKeydown|iaChatSelectConversation|initSceneBuilderPanel|injectCustomKeyframes|onCanvasDragOver|onCanvasDrop|onCollisionBoxMouseDown|onCollisionBoxResizeMouseDown|onElementMouseDown|onFilterValueFieldChange|onFilterValueModeChange|onFilterValueObjChange|onFilterValueVarChange|onGalleryTileDragStart|onResizeMouseDown|onSceneObjectMouseDown|onSceneObjectResizeMouseDown|openAddTriggerModal|openLeftPanel|openPropsPanel|openScreenAddTriggerModal|openScreenTriggerWizard|openTriggerWizard|reclassifyUserAsset|refreshRuntimeData|restartPersonnageIdlePreview|restoreFloatPanelState|runScreenHeldKeyTriggers|runScreenShowTriggers|runScreenTimerTriggers|saveDialogueBoxStyle|saveGlobalVariable|saveSceneObjectName|saveSceneObjectRole|screenIndexById|screenTriggerAppendLeaf|screenTriggerDeleteAt|screenTriggerOpenAppendActionModal|selectQuizBoxDialogTemplate|selectQuizBoxPageTemplate|showScreen|swapPersonnageCharacter|swapSceneObjectCharacter|switchBuilderTab|syncAlign|toggleDashCreate|triggerAppendLeaf|triggerClickObjectCard|triggerDeleteTrigger|triggerInlineAddBubble|triggerInlineAddQuestion|triggerInlineDeleteBubble|triggerInlineSetBubbleAudio|triggerInlineSetBubbleSpeaker|triggerInlineSetQuestionChoiceCount|triggerInlineSetQuestionChoiceText|triggerInlineSetQuestionCorrectIndex|triggerInlineSetQuestionRewardAmount|triggerInlineUpdateBubbleText|triggerInlineUpdateQuestionText|triggerMoveChainAction|triggerOpenAppendActionModal|triggerRemoveChainAction|triggerSelectObject|uploadUserAsset)$"
|
||||
}
|
||||
],
|
||||
"no-unused-vars": "off",
|
||||
"no-underscore-dangle": "off",
|
||||
"func-names": "off",
|
||||
"no-param-reassign": "off",
|
||||
"no-cond-assign": ["error", "except-parens"],
|
||||
"no-empty": ["error", { "allowEmptyCatch": true }],
|
||||
"guard-for-in": "off",
|
||||
"no-unused-expressions": "off",
|
||||
"no-return-assign": "off",
|
||||
"consistent-return": "off",
|
||||
"no-bitwise": "off",
|
||||
"no-plusplus": "off",
|
||||
"no-restricted-syntax": "off",
|
||||
"prefer-destructuring": "off",
|
||||
"no-useless-concat": "off",
|
||||
"no-console": "off",
|
||||
"no-nested-ternary": "off",
|
||||
"no-void": "off",
|
||||
"no-continue": "off",
|
||||
"implicit-arrow-linebreak": "off",
|
||||
"no-use-before-define": ["error", { "functions": false, "classes": true, "variables": true }]
|
||||
},
|
||||
"overrides": [
|
||||
{
|
||||
"files": ["static/js/**/__tests__/**/*.test.js"],
|
||||
"env": { "node": true, "browser": true },
|
||||
"parserOptions": { "sourceType": "script" }
|
||||
},
|
||||
{
|
||||
"files": ["static/js/play/**/*.js"],
|
||||
"rules": {
|
||||
"import/extensions": "off",
|
||||
"global-require": "off"
|
||||
}
|
||||
}
|
||||
],
|
||||
"globals": {
|
||||
"COLLISION_ACTION_LABELS": "readonly",
|
||||
"COLLISION_CHAIN_CHOICES": "readonly",
|
||||
"COLLISION_TRIGGER_LABELS": "readonly",
|
||||
"CONDITION_OPERATOR_LABELS_MAP": "readonly",
|
||||
"CURRENT_SCREEN_ID": "readonly",
|
||||
"CURRENT_SELECTED_ID": "writable",
|
||||
"DATA_OPERATION_LABELS_MAP": "readonly",
|
||||
"DEFINITIONS_DATA": "readonly",
|
||||
"ELEMENT_ADD_URL": "readonly",
|
||||
"ELEMENT_ANIMATIONS_MAP": "readonly",
|
||||
"ELEMENT_VISIBILITY_LABELS_MAP": "readonly",
|
||||
"FORGE_PLAY_URLS": "readonly",
|
||||
"GAME_SLUG": "readonly",
|
||||
"GLOBAL_VARIABLE_NAMES": "readonly",
|
||||
"SCENE_HEIGHT": "readonly",
|
||||
"SCENE_OBJECT_NAMES": "writable",
|
||||
"SCENE_OBJECT_NAMES_JSON": "readonly",
|
||||
"SCENE_WIDTH": "readonly",
|
||||
"SCREEN_EDIT_URL": "readonly",
|
||||
"SCREEN_ID": "readonly",
|
||||
"SURBRILLANCE_LABELS_MAP": "readonly",
|
||||
"USER_ASSETS_OPTIONS": "readonly",
|
||||
"VIDEO_MODE_LABELS_MAP": "readonly",
|
||||
"_collisionWizard": "writable",
|
||||
"_stopPersonnageIdlePreview": "readonly",
|
||||
"applyObjectProperty": "readonly",
|
||||
"applyOpenRowBindings": "readonly",
|
||||
"applySelectionHighlight": "readonly",
|
||||
"bindClicks": "readonly",
|
||||
"bindHoverTexts": "readonly",
|
||||
"bindHoverTriggers": "readonly",
|
||||
"bindPropsAutosave": "readonly",
|
||||
"clampSceneObjectPosition": "readonly",
|
||||
"closeTriggerModal": "readonly",
|
||||
"collisionRuleThumbHtml": "readonly",
|
||||
"collisionWizardBuildLeafAction": "readonly",
|
||||
"compareValues": "readonly",
|
||||
"debouncedSubmitPropsForm": "readonly",
|
||||
"evaluateConditionClause": "readonly",
|
||||
"evaluateConditionNode": "readonly",
|
||||
"forgeApplyAddRowActionOffline": "readonly",
|
||||
"forgeApplyCtx": "readonly",
|
||||
"forgeApplyDataActionOffline": "readonly",
|
||||
"forgeApplyScoreActionOffline": "readonly",
|
||||
"forgeApplyStatusActionOffline": "readonly",
|
||||
"forgeApplyVariableActionOffline": "readonly",
|
||||
"forgeAttrString": "readonly",
|
||||
"forgeAutoId": "readonly",
|
||||
"forgeCollisionRectFromBox": "readonly",
|
||||
"forgeComputeNewValue": "readonly",
|
||||
"forgeDecodeClauses": "readonly",
|
||||
"forgeDialogueBoxState": "readonly",
|
||||
"forgeEscapeHtml": "readonly",
|
||||
"forgeFilterRepeaterRows": "readonly",
|
||||
"forgeFilterRowsByClauses": "readonly",
|
||||
"forgeHtmlEscape": "readonly",
|
||||
"forgeIsElementVisibleOffline": "readonly",
|
||||
"forgeParentFlexDirection": "readonly",
|
||||
"forgeQuizBoxState": "readonly",
|
||||
"forgeQuizTemplateEffects": "readonly",
|
||||
"forgeRecomputeFullPayloadOffline": "readonly",
|
||||
"forgeRenderCheckboxOrRadio": "readonly",
|
||||
"forgeRenderChildren": "readonly",
|
||||
"forgeRenderElementHtml": "readonly",
|
||||
"forgeRenderFieldset": "readonly",
|
||||
"forgeRenderIcone": "readonly",
|
||||
"forgeRenderJauge": "readonly",
|
||||
"forgeRenderOnglets": "readonly",
|
||||
"forgeRenderOverlay": "readonly",
|
||||
"forgeRenderPersonnage": "readonly",
|
||||
"forgeRenderRepeater": "readonly",
|
||||
"forgeRenderSelect": "readonly",
|
||||
"forgeRenderTable": "readonly",
|
||||
"forgeResolveFilterValue": "readonly",
|
||||
"forgeResolveVariablePath": "readonly",
|
||||
"forgeRunCollisionRuleAction": "readonly",
|
||||
"forgeRunScreenTriggers": "readonly",
|
||||
"forgeScorm2004NotifyQuestionAnswered": "readonly",
|
||||
"forgeScormApi": "readonly",
|
||||
"forgeShapesOverlap": "readonly",
|
||||
"forgeShowDialogueBox": "readonly",
|
||||
"forgeShowVideoOverlay": "readonly",
|
||||
"forgeStartCollisionRuleControllers": "readonly",
|
||||
"forgeStartPersonnageControllers": "readonly",
|
||||
"forgeStyleString": "readonly",
|
||||
"forgeUpdateAllScoreWidgets": "readonly",
|
||||
"forgeVisibleAttrs": "readonly",
|
||||
"forgeXapiNotifyDialogueCompleted": "readonly",
|
||||
"forgeXapiNotifyQuestionAnswered": "readonly",
|
||||
"forgeXapiNotifyScoreChanged": "readonly",
|
||||
"forgeXapiNotifyStatusChanged": "readonly",
|
||||
"gameData": "writable",
|
||||
"goToSelected": "readonly",
|
||||
"heldKeys": "readonly",
|
||||
"initBuilderPanel": "readonly",
|
||||
"initIaTab": "readonly",
|
||||
"initSceneBuilderPanel": "readonly",
|
||||
"initTriggersTab": "readonly",
|
||||
"openPropsPanel": "readonly",
|
||||
"openScreenTriggerWizard": "readonly",
|
||||
"openTriggerWizard": "readonly",
|
||||
"refreshRuntimeData": "readonly",
|
||||
"renderCollisionWizardChainStep": "readonly",
|
||||
"resolveSpriteFrames": "readonly",
|
||||
"restartPersonnageIdlePreview": "readonly",
|
||||
"restoreFloatPanelState": "readonly",
|
||||
"restoreTreeCollapsedState": "readonly",
|
||||
"runActionNode": "readonly",
|
||||
"runFlowFrom": "readonly",
|
||||
"runScreenHeldKeyTriggers": "readonly",
|
||||
"runScreenShowTriggers": "readonly",
|
||||
"runScreenTimerTriggers": "readonly",
|
||||
"runSpriteAnimation": "readonly",
|
||||
"saveGeometry": "readonly",
|
||||
"screenIndexById": "readonly",
|
||||
"screenTriggerLoadAll": "readonly",
|
||||
"screensData": "writable",
|
||||
"showScreen": "readonly",
|
||||
"startAllPersonnagePreviews": "readonly",
|
||||
"stopAllSpriteAnimations": "readonly",
|
||||
"submitPropsForm": "readonly",
|
||||
"triggerLoadAll": "readonly"
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user