Phase 3 : hardening qualite de code - typage strict, securite, dead code, a11y

Config strictement stricte partout (ruff, mypy --strict, bandit, vulture,
import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas
casser le build" - l'existant a ete corrige pour la satisfaire plutot que
l'inverse. Hooks pre-commit locaux (language: system) bloquants.

- Typage mypy --strict propage a tout le moteur (db, screens, auth, core,
  ai, routes, puis publish/scripts/tests/app.py/build_css.py).
- Securite : fuite de handle fichier Windows corrigee dans l'export SCORM
  (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes
  (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe
  "</script>" dans le JSON embarque en <script>, 25 sites).
- Architecture : imports circulaires/F811 nettoyes, contrats
  import-linter respectes, code mort retire (vulture).
- Accessibilite : 69 champs de formulaire sans label correctement
  associe corriges (for/id ou aria-label) sur 11 templates.
- ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis
  appliquees (aucune desactivee sans verification individuelle).
- Tests : isolation du compte admin partage (nettoyage ponctuel +
  fixture de teardown automatique en filet de securite), suite complete
  verte (591 tests Python, 241 tests JS).
- SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport
  complet analyse point par point, faux positifs documentes.
- .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine
  faisait echouer ESLint (linebreak-style) via un bug connu de git
  (checkout "en place" qui ignore l'eol force sur un fichier deja
  present sur disque - contourne en supprimant puis recreant chaque
  fichier suivi).

djLint (H021, styles inline) volontairement saute pour ce commit -
backlog assume, deja documente, traite dans un lot separe.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

routes/auth/__init__.py

@@ -1 +1,10 @@
-from . import register, register_2fa, login, login_2fa, logout, forgot_password, reset_password, profile
+from . import (  # noqa: F401 - enregistre les routes definies dans ce sous-module
+    forgot_password,
+    login,
+    login_2fa,
+    logout,
+    profile,
+    register,
+    register_2fa,
+    reset_password,
+)

routes/auth/forgot_password.py

@@ -1,12 +1,12 @@
 from flask import current_app, redirect, render_template, request, session, url_for
+from werkzeug.wrappers import Response
 
 import auth
-
 from core.flask_app import app
 
 
 @app.route("/forgot-password", methods=["GET", "POST"])
-def forgot_password():
+def forgot_password() -> str | Response:
     if session.get("user_id"):
         return redirect(url_for("index"))
     sent = False

routes/auth/login.py

@@ -1,12 +1,12 @@
 from flask import redirect, render_template, request, session, url_for
+from werkzeug.wrappers import Response
 
 import auth
-
 from core.flask_app import app
 
 
 @app.route("/login", methods=["GET", "POST"])
-def login():
+def login() -> str | Response:
     if session.get("user_id"):
         return redirect(url_for("index"))
     error = None

routes/auth/login_2fa.py

@@ -1,12 +1,12 @@
 from flask import redirect, render_template, request, session, url_for
+from werkzeug.wrappers import Response
 
 import auth
-
 from core.flask_app import app
 
 
 @app.route("/login/2fa", methods=["GET", "POST"])
-def login_2fa():
+def login_2fa() -> str | Response:
     user_id = session.get("pending_login_user_id")
     if not user_id:
         return redirect(url_for("login"))

routes/auth/logout.py

@@ -1,9 +1,10 @@
 from flask import redirect, session, url_for
+from werkzeug.wrappers import Response
 
 from core.flask_app import app
 
 
 @app.route("/logout", methods=["POST"])
-def logout():
+def logout() -> Response:
     session.clear()
     return redirect(url_for("login"))

routes/auth/profile.py

@@ -1,28 +1,31 @@
 import os
 
 from flask import g, redirect, render_template, request, session, url_for
+from werkzeug.wrappers import Response
 
 import auth
 import db
-
 from core.flask_app import app
 
 
-def _render(error=None, success=None):
+def _render(error: str | None = None, success: str | None = None) -> str:
     user = auth.get_user_by_id(g.current_user["id"])
     return render_template(
-        "auth/profile.html", user=user, error=error, success=success,
+        "auth/profile.html",
+        user=user,
+        error=error,
+        success=success,
         min_score_required=auth.MIN_SCORE_REQUIRED,
     )
 
 
 @app.route("/profile", methods=["GET"])
-def profile():
+def profile() -> str:
     return _render()
 
 
 @app.route("/profile/update-name", methods=["POST"])
-def profile_update_name():
+def profile_update_name() -> str:
     nom = request.form.get("nom", "").strip()
     prenom = request.form.get("prenom", "").strip()
     if not nom or not prenom:
@@ -32,7 +35,7 @@ def profile_update_name():
 
 
 @app.route("/profile/update-email", methods=["POST"])
-def profile_update_email():
+def profile_update_email() -> str:
     user = g.current_user
     current_password = request.form.get("current_password", "")
     new_email = request.form.get("email", "").strip().lower()
@@ -50,7 +53,7 @@ def profile_update_email():
 
 
 @app.route("/profile/regenerate-recovery-codes", methods=["POST"])
-def profile_regenerate_recovery_codes():
+def profile_regenerate_recovery_codes() -> str:
     user = g.current_user
     current_password = request.form.get("current_password", "")
     if not auth.verify_password(user, current_password):
@@ -64,7 +67,7 @@ def profile_regenerate_recovery_codes():
 
 
 @app.route("/profile/change-password", methods=["POST"])
-def profile_change_password():
+def profile_change_password() -> str:
     user = g.current_user
     current_password = request.form.get("current_password", "")
     new_password = request.form.get("new_password", "")
@@ -80,7 +83,7 @@ def profile_change_password():
 
 
 @app.route("/profile/delete", methods=["POST"])
-def profile_delete():
+def profile_delete() -> str | Response:
     user = g.current_user
     current_password = request.form.get("current_password", "")
     confirm_text = request.form.get("confirm_text", "").strip().upper()
@@ -98,13 +101,12 @@ def profile_delete():
     # sur le disque sans plus aucun propriétaire. Un "admin" peut posséder
     # plusieurs jeux qui ne lui sont pas dédiés de la même façon : ses
     # projets restent intacts.
-    if user["role"] != "admin" and user.get("project_slug"):
-        if os.path.isdir(db.game_dir(user["project_slug"])):
-            # db.delete_game (voir db/games/project_slug.py — structure de
-            # dossiers par utilisateur) nettoie aussi le dossier
-            # propriétaire s'il devient vide, contrairement à un simple
-            # shutil.rmtree du dossier projet seul.
-            db.delete_game(user["project_slug"])
+    if user["role"] != "admin" and user.get("project_slug") and os.path.isdir(db.game_dir(user["project_slug"])):
+        # db.delete_game (voir db/games/project_slug.py — structure de
+        # dossiers par utilisateur) nettoie aussi le dossier
+        # propriétaire s'il devient vide, contrairement à un simple
+        # shutil.rmtree du dossier projet seul.
+        db.delete_game(user["project_slug"])
 
     auth.delete_user(user["id"])
     session.clear()

routes/auth/register.py

@@ -1,12 +1,12 @@
 from flask import redirect, render_template, request, session, url_for
+from werkzeug.wrappers import Response
 
 import auth
-
 from core.flask_app import app
 
 
 @app.route("/register", methods=["GET", "POST"])
-def register():
+def register() -> str | Response:
     error = None
     form = {"email": "", "nom": "", "prenom": ""}
     if request.method == "POST":
@@ -31,6 +31,8 @@ def register():
                 session["pending_register_user_id"] = user_id
                 return redirect(url_for("register_2fa"))
     return render_template(
-        "auth/register.html", error=error, form=form,
+        "auth/register.html",
+        error=error,
+        form=form,
         min_score_required=auth.MIN_SCORE_REQUIRED,
     )

routes/auth/register_2fa.py

@@ -1,12 +1,12 @@
 from flask import redirect, render_template, request, session, url_for
+from werkzeug.wrappers import Response
 
 import auth
-
 from core.flask_app import app
 
 
 @app.route("/register/2fa", methods=["GET", "POST"])
-def register_2fa():
+def register_2fa() -> str | Response:
     user_id = session.get("pending_register_user_id")
     if not user_id:
         return redirect(url_for("register"))
@@ -22,8 +22,11 @@ def register_2fa():
             error = auth.lockout_message(locked_seconds)
         elif not auth.verify_totp(user["totp_secret"], request.form.get("code", "")):
             just_locked_minutes = auth.record_failed_attempt(user_id)
-            error = auth.lockout_message(just_locked_minutes * 60) if just_locked_minutes else \
-                "Code invalide — vérifie l'heure de ton téléphone et réessaie."
+            error = (
+                auth.lockout_message(just_locked_minutes * 60)
+                if just_locked_minutes
+                else "Code invalide — vérifie l'heure de ton téléphone et réessaie."
+            )
         else:
             auth.reset_failed_attempts(user_id)
             auth.confirm_totp(user_id)
@@ -50,6 +53,9 @@ def register_2fa():
 
     qr_svg = auth.totp_qrcode_svg(user["totp_secret"], user["email"])
     return render_template(
-        "auth/register_2fa.html", error=error, qr_svg=qr_svg,
-        secret=user["totp_secret"], email=user["email"],
+        "auth/register_2fa.html",
+        error=error,
+        qr_svg=qr_svg,
+        secret=user["totp_secret"],
+        email=user["email"],
     )

routes/auth/reset_password.py

@@ -1,12 +1,12 @@
 from flask import redirect, render_template, request, url_for
+from werkzeug.wrappers import Response
 
 import auth
-
 from core.flask_app import app
 
 
 @app.route("/reset-password/<token>", methods=["GET", "POST"])
-def reset_password(token):
+def reset_password(token: str) -> str | Response:
     user_id = auth.get_user_id_for_valid_token(token)
     if not user_id:
         return render_template("auth/reset_password.html", invalid=True)
@@ -24,6 +24,8 @@ def reset_password(token):
             auth.consume_password_reset_token(token)
             return redirect(url_for("login"))
     return render_template(
-        "auth/reset_password.html", invalid=False, error=error,
+        "auth/reset_password.html",
+        invalid=False,
+        error=error,
         min_score_required=auth.MIN_SCORE_REQUIRED,
     )