Phase 3 : hardening qualite de code - typage strict, securite, dead code, a11y
Config strictement stricte partout (ruff, mypy --strict, bandit, vulture, import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas casser le build" - l'existant a ete corrige pour la satisfaire plutot que l'inverse. Hooks pre-commit locaux (language: system) bloquants. - Typage mypy --strict propage a tout le moteur (db, screens, auth, core, ai, routes, puis publish/scripts/tests/app.py/build_css.py). - Securite : fuite de handle fichier Windows corrigee dans l'export SCORM (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe "</script>" dans le JSON embarque en <script>, 25 sites). - Architecture : imports circulaires/F811 nettoyes, contrats import-linter respectes, code mort retire (vulture). - Accessibilite : 69 champs de formulaire sans label correctement associe corriges (for/id ou aria-label) sur 11 templates. - ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis appliquees (aucune desactivee sans verification individuelle). - Tests : isolation du compte admin partage (nettoyage ponctuel + fixture de teardown automatique en filet de securite), suite complete verte (591 tests Python, 241 tests JS). - SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport complet analyse point par point, faux positifs documentes. - .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine faisait echouer ESLint (linebreak-style) via un bug connu de git (checkout "en place" qui ignore l'eol force sur un fichier deja present sur disque - contourne en supprimant puis recreant chaque fichier suivi). djLint (H021, styles inline) volontairement saute pour ce commit - backlog assume, deja documente, traite dans un lot separe. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Sonnet 5
parent
7db4803b93
commit
c57420c8c9
@@ -1 +1,5 @@
|
||||
from . import flow_block_new, flow_block_edit, flow_block_delete
|
||||
from . import ( # noqa: F401 - enregistre les routes definies dans chaque module
|
||||
flow_block_delete,
|
||||
flow_block_edit,
|
||||
flow_block_new,
|
||||
)
|
||||
|
||||
@@ -1,12 +1,12 @@
|
||||
from flask import redirect, url_for
|
||||
from werkzeug.wrappers import Response
|
||||
|
||||
import screens
|
||||
|
||||
from core.flask_app import app
|
||||
|
||||
|
||||
@app.route("/game/<slug>/screens/<int:screen_id>/flow/blocks/<int:block_id>/delete", methods=["POST"])
|
||||
def flow_block_delete(slug, screen_id, block_id):
|
||||
def flow_block_delete(slug: str, screen_id: int, block_id: int) -> Response:
|
||||
"""Supprime le bloc ET tous ses nœuds/arêtes (voir
|
||||
screens/flow/blocks/delete_flow_block.py) — confirmation côté client
|
||||
avant l'envoi, affichant le nombre de nœuds concernés."""
|
||||
|
||||
@@ -1,12 +1,12 @@
|
||||
from flask import request, redirect, url_for
|
||||
from flask import redirect, request, url_for
|
||||
from werkzeug.wrappers import Response
|
||||
|
||||
import screens
|
||||
|
||||
from core.flask_app import app
|
||||
|
||||
|
||||
@app.route("/game/<slug>/screens/<int:screen_id>/flow/blocks/<int:block_id>/edit", methods=["POST"])
|
||||
def flow_block_edit(slug, screen_id, block_id):
|
||||
def flow_block_edit(slug: str, screen_id: int, block_id: int) -> Response:
|
||||
name = (request.form.get("name") or "").strip()
|
||||
description = request.form.get("description") or ""
|
||||
screens.update_flow_block(slug, block_id, name, description)
|
||||
|
||||
@@ -1,12 +1,12 @@
|
||||
from flask import request, redirect, url_for
|
||||
from flask import redirect, request, url_for
|
||||
from werkzeug.wrappers import Response
|
||||
|
||||
import screens
|
||||
|
||||
from core.flask_app import app
|
||||
|
||||
|
||||
@app.route("/game/<slug>/screens/<int:screen_id>/flow/blocks/new", methods=["POST"])
|
||||
def flow_block_new(slug, screen_id):
|
||||
def flow_block_new(slug: str, screen_id: int) -> Response:
|
||||
name = (request.form.get("name") or "").strip()
|
||||
description = request.form.get("description") or ""
|
||||
if name:
|
||||
|
||||
Reference in New Issue
Block a user