Phase 3 : hardening qualite de code - typage strict, securite, dead code, a11y
Config strictement stricte partout (ruff, mypy --strict, bandit, vulture, import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas casser le build" - l'existant a ete corrige pour la satisfaire plutot que l'inverse. Hooks pre-commit locaux (language: system) bloquants. - Typage mypy --strict propage a tout le moteur (db, screens, auth, core, ai, routes, puis publish/scripts/tests/app.py/build_css.py). - Securite : fuite de handle fichier Windows corrigee dans l'export SCORM (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe "</script>" dans le JSON embarque en <script>, 25 sites). - Architecture : imports circulaires/F811 nettoyes, contrats import-linter respectes, code mort retire (vulture). - Accessibilite : 69 champs de formulaire sans label correctement associe corriges (for/id ou aria-label) sur 11 templates. - ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis appliquees (aucune desactivee sans verification individuelle). - Tests : isolation du compte admin partage (nettoyage ponctuel + fixture de teardown automatique en filet de securite), suite complete verte (591 tests Python, 241 tests JS). - SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport complet analyse point par point, faux positifs documentes. - .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine faisait echouer ESLint (linebreak-style) via un bug connu de git (checkout "en place" qui ignore l'eol force sur un fichier deja present sur disque - contourne en supprimant puis recreant chaque fichier suivi). djLint (H021, styles inline) volontairement saute pour ce commit - backlog assume, deja documente, traite dans un lot separe. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Sonnet 5
parent
7db4803b93
commit
c57420c8c9
@@ -1,4 +1,5 @@
|
||||
import json
|
||||
from typing import Any
|
||||
|
||||
import db
|
||||
|
||||
@@ -7,15 +8,25 @@ from .ensure_animation_schema import ensure_animation_schema
|
||||
# Point de départ raisonnable pour un nouveau clip "personnalisé" : un
|
||||
# fondu simple de 0 à 1, que le créateur du jeu peut ensuite modifier ou
|
||||
# remplacer entièrement dans l'éditeur de images-clés.
|
||||
_DEFAULT_CUSTOM_KEYFRAMES = [
|
||||
_DEFAULT_CUSTOM_KEYFRAMES: list[dict[str, Any]] = [
|
||||
{"percent": 0, "props": {"opacity": "0"}},
|
||||
{"percent": 100, "props": {"opacity": "1"}},
|
||||
]
|
||||
|
||||
|
||||
def add_animation_clip(slug, screen_id, element_id, kind="animate_css", animate_name=None,
|
||||
custom_keyframes=None, start_time=0, duration=1, delay=0,
|
||||
easing="ease", iteration_count="1"):
|
||||
def add_animation_clip(
|
||||
slug: str,
|
||||
screen_id: int,
|
||||
element_id: int,
|
||||
kind: str = "animate_css",
|
||||
animate_name: str | None = None,
|
||||
custom_keyframes: list[dict[str, Any]] | None = None,
|
||||
start_time: float = 0,
|
||||
duration: float = 1,
|
||||
delay: float = 0,
|
||||
easing: str = "ease",
|
||||
iteration_count: str = "1",
|
||||
) -> int:
|
||||
ensure_animation_schema(slug)
|
||||
if kind == "custom" and not custom_keyframes:
|
||||
custom_keyframes = _DEFAULT_CUSTOM_KEYFRAMES
|
||||
@@ -28,10 +39,20 @@ def add_animation_clip(slug, screen_id, element_id, kind="animate_css", animate_
|
||||
(screen_id, element_id, kind, animate_name, custom_keyframes,
|
||||
start_time, duration, delay, easing, iteration_count)
|
||||
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)""",
|
||||
(screen_id, element_id, kind, animate_name, keyframes_json,
|
||||
float(start_time), float(duration), float(delay), easing, str(iteration_count)),
|
||||
(
|
||||
screen_id,
|
||||
element_id,
|
||||
kind,
|
||||
animate_name,
|
||||
keyframes_json,
|
||||
float(start_time),
|
||||
float(duration),
|
||||
float(delay),
|
||||
easing,
|
||||
str(iteration_count),
|
||||
),
|
||||
)
|
||||
clip_id = conn.execute("SELECT last_insert_rowid() AS id").fetchone()["id"]
|
||||
clip_id = int(conn.execute("SELECT last_insert_rowid() AS id").fetchone()["id"])
|
||||
conn.commit()
|
||||
conn.close()
|
||||
return clip_id
|
||||
|
||||
Reference in New Issue
Block a user