Phase 3 : hardening qualite de code - typage strict, securite, dead code, a11y
Config strictement stricte partout (ruff, mypy --strict, bandit, vulture, import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas casser le build" - l'existant a ete corrige pour la satisfaire plutot que l'inverse. Hooks pre-commit locaux (language: system) bloquants. - Typage mypy --strict propage a tout le moteur (db, screens, auth, core, ai, routes, puis publish/scripts/tests/app.py/build_css.py). - Securite : fuite de handle fichier Windows corrigee dans l'export SCORM (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe "</script>" dans le JSON embarque en <script>, 25 sites). - Architecture : imports circulaires/F811 nettoyes, contrats import-linter respectes, code mort retire (vulture). - Accessibilite : 69 champs de formulaire sans label correctement associe corriges (for/id ou aria-label) sur 11 templates. - ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis appliquees (aucune desactivee sans verification individuelle). - Tests : isolation du compte admin partage (nettoyage ponctuel + fixture de teardown automatique en filet de securite), suite complete verte (591 tests Python, 241 tests JS). - SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport complet analyse point par point, faux positifs documentes. - .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine faisait echouer ESLint (linebreak-style) via un bug connu de git (checkout "en place" qui ignore l'eol force sur un fichier deja present sur disque - contourne en supprimant puis recreant chaque fichier suivi). djLint (H021, styles inline) volontairement saute pour ce commit - backlog assume, deja documente, traite dans un lot separe. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Sonnet 5
parent
7db4803b93
commit
c57420c8c9
@@ -10,9 +10,11 @@ par le moteur.
|
||||
Accès réservé au rôle admin (voir screens/labels/animal_sprite_library.py,
|
||||
routes/screens/screen_edit.py, routes/scenes/scene_edit_view.py) : licence
|
||||
CraftPix, ne redistribue pas ces sprites à des comptes "user"."""
|
||||
|
||||
import json
|
||||
import os
|
||||
import shutil
|
||||
from typing import Any
|
||||
|
||||
_BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
|
||||
_SRC_ROOT = os.path.join(_BASE_DIR, "assets", "characters", "animal_sprite")
|
||||
@@ -39,16 +41,23 @@ _PACKS = {
|
||||
# Nom de pose source (dossier Png/CharacterNN/<Pose>) -> nom exposé (clé
|
||||
# d'animation). "Stuned" est une coquille du pack source, corrigée ici.
|
||||
_POSE_NAMES = {
|
||||
"Idle": "idle", "Walk": "walk", "Jump": "jump", "Fly": "fly",
|
||||
"Roll": "roll", "Hit": "hit", "Stuned": "stunned",
|
||||
"Throwing": "throwing", "Dead": "dead",
|
||||
"Idle": "idle",
|
||||
"Walk": "walk",
|
||||
"Jump": "jump",
|
||||
"Fly": "fly",
|
||||
"Roll": "roll",
|
||||
"Hit": "hit",
|
||||
"Stuned": "stunned",
|
||||
"Throwing": "throwing",
|
||||
"Dead": "dead",
|
||||
}
|
||||
|
||||
def _copy_variant(pack_dir, animal, nn):
|
||||
|
||||
def _copy_variant(pack_dir: str, animal: str, nn: str) -> dict[str, int] | None:
|
||||
char_dir = os.path.join(pack_dir, "Png", f"Character{nn}")
|
||||
if not os.path.isdir(char_dir):
|
||||
return None
|
||||
poses = {}
|
||||
poses: dict[str, int] = {}
|
||||
for pose_folder in sorted(os.listdir(char_dir)):
|
||||
exposed = _POSE_NAMES.get(pose_folder)
|
||||
if not exposed:
|
||||
@@ -65,14 +74,14 @@ def _copy_variant(pack_dir, animal, nn):
|
||||
return poses or None
|
||||
|
||||
|
||||
def main():
|
||||
manifest = {}
|
||||
def main() -> None:
|
||||
manifest: dict[str, Any] = {}
|
||||
for pack_folder, (animal, label) in sorted(_PACKS.items()):
|
||||
pack_dir = os.path.join(_SRC_ROOT, pack_folder)
|
||||
if not os.path.isdir(pack_dir):
|
||||
print(f"SKIP (introuvable) : {pack_folder}")
|
||||
continue
|
||||
variants = {}
|
||||
variants: dict[str, Any] = {}
|
||||
for n in range(1, 16):
|
||||
nn = f"{n:02d}"
|
||||
poses = _copy_variant(pack_dir, animal, nn)
|
||||
|
||||
Reference in New Issue
Block a user