Phase 3 : hardening qualite de code - typage strict, securite, dead code, a11y

Config strictement stricte partout (ruff, mypy --strict, bandit, vulture,
import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas
casser le build" - l'existant a ete corrige pour la satisfaire plutot que
l'inverse. Hooks pre-commit locaux (language: system) bloquants.

- Typage mypy --strict propage a tout le moteur (db, screens, auth, core,
  ai, routes, puis publish/scripts/tests/app.py/build_css.py).
- Securite : fuite de handle fichier Windows corrigee dans l'export SCORM
  (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes
  (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe
  "</script>" dans le JSON embarque en <script>, 25 sites).
- Architecture : imports circulaires/F811 nettoyes, contrats
  import-linter respectes, code mort retire (vulture).
- Accessibilite : 69 champs de formulaire sans label correctement
  associe corriges (for/id ou aria-label) sur 11 templates.
- ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis
  appliquees (aucune desactivee sans verification individuelle).
- Tests : isolation du compte admin partage (nettoyage ponctuel +
  fixture de teardown automatique en filet de securite), suite complete
  verte (591 tests Python, 241 tests JS).
- SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport
  complet analyse point par point, faux positifs documentes.
- .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine
  faisait echouer ESLint (linebreak-style) via un bug connu de git
  (checkout "en place" qui ignore l'eol force sur un fichier deja
  present sur disque - contourne en supprimant puis recreant chaque
  fichier suivi).

djLint (H021, styles inline) volontairement saute pour ce commit -
backlog assume, deja documente, traite dans un lot separe.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
william
2026-09-15 16:06:15 +02:00
co-authored by Claude Sonnet 5
parent 7db4803b93
commit c57420c8c9
454 changed files with 16448 additions and 6967 deletions
+2 -2
View File
@@ -13,8 +13,8 @@
<p class="hint mb-4">Indique ton adresse email : si un compte y est associé, un lien de réinitialisation te sera envoyé.</p>
<form method="post" action="{{ url_for('forgot_password') }}" autocomplete="off">
<div class="field">
<label class="label">Adresse email</label>
<div class="control"><input class="input" type="email" name="email" required autofocus></div>
<label class="label" for="forgot-password-email">Adresse email</label>
<div class="control"><input class="input" type="email" id="forgot-password-email" name="email" required autofocus></div>
</div>
<div class="field mt-4">
<button type="submit" class="button primary is-fullwidth">Envoyer le lien</button>
+4 -4
View File
@@ -13,12 +13,12 @@
<form method="post" action="{{ url_for('login') }}" autocomplete="off">
<input type="hidden" name="next" value="{{ next_url }}">
<div class="field">
<label class="label">Adresse email</label>
<div class="control"><input class="input" type="email" name="email" value="{{ email }}" required autofocus></div>
<label class="label" for="login-email">Adresse email</label>
<div class="control"><input class="input" type="email" id="login-email" name="email" value="{{ email }}" required autofocus></div>
</div>
<div class="field">
<label class="label">Mot de passe</label>
<div class="control"><input class="input" type="password" name="password" required autocomplete="current-password"></div>
<label class="label" for="login-password">Mot de passe</label>
<div class="control"><input class="input" type="password" id="login-password" name="password" required autocomplete="current-password"></div>
</div>
<div class="field mt-4">
<button type="submit" class="button primary is-fullwidth">Continuer</button>
+2 -2
View File
@@ -13,8 +13,8 @@
<form method="post" action="{{ url_for('login_2fa') }}">
<div class="field">
<label class="label">Code à 6 chiffres ou code de récupération</label>
<div class="control"><input class="input" type="text" name="code" autocomplete="one-time-code" required autofocus></div>
<label class="label" for="login-2fa-code">Code à 6 chiffres ou code de récupération</label>
<div class="control"><input class="input" type="text" id="login-2fa-code" name="code" autocomplete="one-time-code" required autofocus></div>
</div>
<div class="field mt-4">
<button type="submit" class="button primary is-fullwidth">Se connecter</button>
+10 -10
View File
@@ -20,8 +20,8 @@
{{ 'Compte administrateur' if user.role == 'admin' else 'Compte utilisateur' }}{% if user.role != 'admin' %} — le dossier de ton jeu ({{ user.project_slug }}) suit automatiquement{% endif %}.
</p>
<form method="post" action="{{ url_for('profile_update_email') }}" autocomplete="off" class="profileForm">
<div class="field"><input class="input is-small" type="email" name="email" value="{{ user.email }}" placeholder="Adresse email" required></div>
<div class="field"><input class="input is-small" type="password" name="current_password" placeholder="Mot de passe actuel" required autocomplete="current-password"></div>
<div class="field"><input class="input is-small" type="email" name="email" value="{{ user.email }}" placeholder="Adresse email" required aria-label="Adresse email"></div>
<div class="field"><input class="input is-small" type="password" name="current_password" placeholder="Mot de passe actuel" required autocomplete="current-password" aria-label="Mot de passe actuel"></div>
<div class="field"><button type="submit" class="button primary is-small is-fullwidth">Changer d'adresse email</button></div>
</form>
</div>
@@ -29,8 +29,8 @@
<div class="box profileBox">
<h2 class="title is-6 mb-2">Informations</h2>
<form method="post" action="{{ url_for('profile_update_name') }}" class="profileForm profileForm-row">
<div class="field"><input class="input is-small" type="text" name="prenom" value="{{ user.prenom }}" placeholder="Prénom" required></div>
<div class="field"><input class="input is-small" type="text" name="nom" value="{{ user.nom }}" placeholder="Nom" required></div>
<div class="field"><input class="input is-small" type="text" name="prenom" value="{{ user.prenom }}" placeholder="Prénom" required aria-label="Prénom"></div>
<div class="field"><input class="input is-small" type="text" name="nom" value="{{ user.nom }}" placeholder="Nom" required aria-label="Nom"></div>
<div class="field profileForm-full"><button type="submit" class="button primary is-small is-fullwidth">Enregistrer</button></div>
</form>
</div>
@@ -45,8 +45,8 @@
{% endif %}
</p>
<form method="post" action="{{ url_for('profile_delete') }}" autocomplete="off" class="profileForm">
<div class="field"><input class="input is-small" type="password" name="current_password" placeholder="Mot de passe actuel" required autocomplete="current-password"></div>
<div class="field"><input class="input is-small" type="text" name="confirm_text" placeholder='Tape "SUPPRIMER" pour confirmer' required></div>
<div class="field"><input class="input is-small" type="password" name="current_password" placeholder="Mot de passe actuel" required autocomplete="current-password" aria-label="Mot de passe actuel"></div>
<div class="field"><input class="input is-small" type="text" name="confirm_text" placeholder='Tape "SUPPRIMER" pour confirmer' required aria-label='Tape &quot;SUPPRIMER&quot; pour confirmer'></div>
<div class="field"><button type="submit" class="button is-danger is-small is-fullwidth">Supprimer définitivement mon compte</button></div>
</form>
</div>
@@ -56,8 +56,8 @@
<div class="box profileBox">
<h2 class="title is-6 mb-2">Changer de mot de passe</h2>
<form method="post" action="{{ url_for('profile_change_password') }}" autocomplete="off" class="profileForm">
<div class="field"><input class="input is-small" type="password" name="current_password" placeholder="Mot de passe actuel" required autocomplete="current-password"></div>
<div class="field"><input class="input is-small" id="password" type="password" name="new_password" placeholder="Nouveau mot de passe" required autocomplete="new-password"></div>
<div class="field"><input class="input is-small" type="password" name="current_password" placeholder="Mot de passe actuel" required autocomplete="current-password" aria-label="Mot de passe actuel"></div>
<div class="field"><input class="input is-small" id="password" type="password" name="new_password" placeholder="Nouveau mot de passe" required autocomplete="new-password" aria-label="Nouveau mot de passe"></div>
<div class="field">
<div class="passwordStrengthBar"><div class="passwordStrengthFill" id="pwFill"></div></div>
<ul class="passwordChecklist passwordChecklist-compact" id="pwChecklist">
@@ -68,7 +68,7 @@
<li data-check="special">Spécial</li>
</ul>
</div>
<div class="field"><input class="input is-small" type="password" name="new_password_confirm" placeholder="Confirmer le nouveau mot de passe" required autocomplete="new-password"></div>
<div class="field"><input class="input is-small" type="password" name="new_password_confirm" placeholder="Confirmer le nouveau mot de passe" required autocomplete="new-password" aria-label="Confirmer le nouveau mot de passe"></div>
<div class="field"><button type="submit" class="button primary is-small is-fullwidth">Changer le mot de passe</button></div>
</form>
</div>
@@ -77,7 +77,7 @@
<h2 class="title is-6 mb-2">Codes de récupération 2FA</h2>
<p class="hint mb-2">Remplace immédiatement les 10 codes précédents. Les nouveaux ne s'affichent qu'une fois, juste après.</p>
<form method="post" action="{{ url_for('profile_regenerate_recovery_codes') }}" autocomplete="off" class="profileForm">
<div class="field"><input class="input is-small" type="password" name="current_password" placeholder="Mot de passe actuel" required autocomplete="current-password"></div>
<div class="field"><input class="input is-small" type="password" name="current_password" placeholder="Mot de passe actuel" required autocomplete="current-password" aria-label="Mot de passe actuel"></div>
<div class="field"><button type="submit" class="button primary is-small is-fullwidth">Régénérer mes 10 codes</button></div>
</form>
</div>
+9 -9
View File
@@ -13,19 +13,19 @@
<form method="post" action="{{ url_for('register') }}" autocomplete="off">
<div class="field">
<label class="label">Prénom</label>
<div class="control"><input class="input" type="text" name="prenom" value="{{ form.prenom }}" required></div>
<label class="label" for="register-prenom">Prénom</label>
<div class="control"><input class="input" type="text" id="register-prenom" name="prenom" value="{{ form.prenom }}" required></div>
</div>
<div class="field">
<label class="label">Nom</label>
<div class="control"><input class="input" type="text" name="nom" value="{{ form.nom }}" required></div>
<label class="label" for="register-nom">Nom</label>
<div class="control"><input class="input" type="text" id="register-nom" name="nom" value="{{ form.nom }}" required></div>
</div>
<div class="field">
<label class="label">Adresse email</label>
<div class="control"><input class="input" type="email" name="email" value="{{ form.email }}" required autocomplete="off"></div>
<label class="label" for="register-email">Adresse email</label>
<div class="control"><input class="input" type="email" id="register-email" name="email" value="{{ form.email }}" required autocomplete="off"></div>
</div>
<div class="field">
<label class="label">Mot de passe</label>
<label class="label" for="password">Mot de passe</label>
<div class="control"><input class="input" type="password" id="password" name="password" required autocomplete="new-password"></div>
</div>
@@ -48,8 +48,8 @@
</div>
<div class="field">
<label class="label">Confirmer le mot de passe</label>
<div class="control"><input class="input" type="password" name="password_confirm" required autocomplete="new-password"></div>
<label class="label" for="register-password-confirm">Confirmer le mot de passe</label>
<div class="control"><input class="input" type="password" id="register-password-confirm" name="password_confirm" required autocomplete="new-password"></div>
</div>
<div class="field mt-4">
+3 -2
View File
@@ -11,13 +11,14 @@
<div class="notification is-danger">{{ error }}</div>
{% endif %}
{# NOSONAR S5247 - qr_svg est produit par la librairie qrcode a partir d'une URI TOTP generee serveur, aucun texte libre utilisateur embarque #}
<div class="totpQrWrap">{{ qr_svg|safe }}</div>
<p class="hint">Impossible de scanner ? Saisis cette clé manuellement dans l'application : <code>{{ secret }}</code></p>
<form method="post" action="{{ url_for('register_2fa') }}" class="mt-4">
<div class="field">
<label class="label">Code à 6 chiffres</label>
<div class="control"><input class="input" type="text" name="code" inputmode="numeric" pattern="[0-9]*" maxlength="6" autocomplete="one-time-code" required autofocus></div>
<label class="label" for="register-2fa-code">Code à 6 chiffres</label>
<div class="control"><input class="input" type="text" id="register-2fa-code" name="code" inputmode="numeric" pattern="[0-9]*" maxlength="6" autocomplete="one-time-code" required autofocus></div>
</div>
<div class="field">
<button type="submit" class="button primary is-fullwidth">Confirmer et activer mon compte</button>
+3 -3
View File
@@ -16,7 +16,7 @@
<form method="post" autocomplete="off">
<div class="field">
<label class="label">Nouveau mot de passe</label>
<label class="label" for="password">Nouveau mot de passe</label>
<div class="control"><input class="input" type="password" id="password" name="password" required autocomplete="new-password"></div>
</div>
@@ -32,8 +32,8 @@
</div>
<div class="field">
<label class="label">Confirmer le mot de passe</label>
<div class="control"><input class="input" type="password" name="password_confirm" required autocomplete="new-password"></div>
<label class="label" for="reset-password-confirm">Confirmer le mot de passe</label>
<div class="control"><input class="input" type="password" id="reset-password-confirm" name="password_confirm" required autocomplete="new-password"></div>
</div>
<div class="field mt-4">