Phase 3 : hardening qualite de code - typage strict, securite, dead code, a11y
Config strictement stricte partout (ruff, mypy --strict, bandit, vulture, import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas casser le build" - l'existant a ete corrige pour la satisfaire plutot que l'inverse. Hooks pre-commit locaux (language: system) bloquants. - Typage mypy --strict propage a tout le moteur (db, screens, auth, core, ai, routes, puis publish/scripts/tests/app.py/build_css.py). - Securite : fuite de handle fichier Windows corrigee dans l'export SCORM (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe "</script>" dans le JSON embarque en <script>, 25 sites). - Architecture : imports circulaires/F811 nettoyes, contrats import-linter respectes, code mort retire (vulture). - Accessibilite : 69 champs de formulaire sans label correctement associe corriges (for/id ou aria-label) sur 11 templates. - ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis appliquees (aucune desactivee sans verification individuelle). - Tests : isolation du compte admin partage (nettoyage ponctuel + fixture de teardown automatique en filet de securite), suite complete verte (591 tests Python, 241 tests JS). - SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport complet analyse point par point, faux positifs documentes. - .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine faisait echouer ESLint (linebreak-style) via un bug connu de git (checkout "en place" qui ignore l'eol force sur un fichier deja present sur disque - contourne en supprimant puis recreant chaque fichier suivi). djLint (H021, styles inline) volontairement saute pour ce commit - backlog assume, deja documente, traite dans un lot separe. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
william
co-authored by
Claude Sonnet 5
Claude Sonnet 5
parent
7db4803b93
commit
c57420c8c9
+34
-33
@@ -54,7 +54,7 @@
|
||||
</div>
|
||||
<div class="floatPanelBody">
|
||||
<form method="post" action="{{ url_for('screen_rename', slug=game.slug, screen_id=screen.id) }}" class="field has-addons" style="align-items:center; margin-bottom:8px;">
|
||||
<div class="control is-expanded"><input class="input is-small" type="text" name="name" value="{{ screen.name }}" required></div>
|
||||
<div class="control is-expanded"><input class="input is-small" type="text" name="name" value="{{ screen.name }}" required aria-label="Nom de l'écran"></div>
|
||||
<div class="control"><button type="submit" class="button is-small">Renommer</button></div>
|
||||
</form>
|
||||
<a class="button is-small is-primary is-fullwidth mb-2" href="{{ url_for('game_play', slug=game.slug) }}" target="_blank">Jouer depuis le début</a>
|
||||
@@ -307,6 +307,7 @@
|
||||
<div class="canvasElement {{ 'selected' if o.id == selected_id else '' }} {{ 'isQuizFullscreenPreview' if o.quiz_fullscreen else '' }}" id="el-{{ o.id }}"
|
||||
style="position:absolute; left:{{ o.x }}px; top:{{ o.y }}px; width:{{ o.width }}px; height:{{ o.height }}px;"
|
||||
onmousedown="onSceneObjectMouseDown(event, {{ o.id }})">
|
||||
{# NOSONAR S5247 - rendered_html vient de render_scene_object() (Python), qui echappe deja tout texte utilisateur via html.escape() #}
|
||||
<div class="canvasElementInner">{{ o.rendered_html|safe }}</div>
|
||||
<div class="resizeHandle" onmousedown="onSceneObjectResizeMouseDown(event, {{ o.id }})"></div>
|
||||
{% if o.id == selected_id and o.kind not in ('fond', 'dialogue_box', 'quiz_box', 'score_widget') %}
|
||||
@@ -353,13 +354,13 @@
|
||||
</div>
|
||||
<p class="hint">Accessibles depuis n'importe quelle scène (conditions, actions "Modifier une variable"). Le nom ne peut plus changer une fois créé.</p>
|
||||
<form class="dashCreateBar" id="dashCreate-variables" style="display:none;" onsubmit="return createGlobalVariable(event);">
|
||||
<input type="text" name="name" placeholder="NOM (ex. score_total)" required autocomplete="off">
|
||||
<select name="type">
|
||||
<input type="text" name="name" placeholder="NOM (ex. score_total)" required autocomplete="off" aria-label="Nom de la variable">
|
||||
<select name="type" aria-label="Type de la variable">
|
||||
{% for key, t in global_variable_types.items() %}
|
||||
<option value="{{ key }}">{{ t.label }}</option>
|
||||
{% endfor %}
|
||||
</select>
|
||||
<input type="text" name="default_value" placeholder="Valeur par défaut">
|
||||
<input type="text" name="default_value" placeholder="Valeur par défaut" aria-label="Valeur par défaut de la variable">
|
||||
<label class="checkbox" style="display:flex; align-items:center; gap:4px; white-space:nowrap;" title="Chaque joueur a sa propre valeur (décoché = valeur unique partagée par tous)">
|
||||
<input type="checkbox" name="per_player" value="1" checked> Par joueur
|
||||
</label>
|
||||
@@ -396,8 +397,8 @@
|
||||
</div>
|
||||
<form method="post" action="{{ url_for('custom_event_new', slug=game.slug) }}" class="dashCreateBar" id="dashCreate-events" style="display:none;">
|
||||
<input type="hidden" name="screen_id" value="{{ screen.id }}">
|
||||
<input type="text" name="name" placeholder="NOM (ex. NEED_ACTION)" required autocomplete="off">
|
||||
<input type="text" name="description" placeholder="Description (optionnel)">
|
||||
<input type="text" name="name" placeholder="NOM (ex. NEED_ACTION)" required autocomplete="off" aria-label="Nom de l'événement">
|
||||
<input type="text" name="description" placeholder="Description (optionnel)" aria-label="Description de l'événement">
|
||||
<button type="submit" class="primary">Créer</button>
|
||||
</form>
|
||||
|
||||
@@ -476,7 +477,7 @@
|
||||
<summary>Informations</summary>
|
||||
<div class="propGroupBody">
|
||||
<div class="field">
|
||||
<label class="label is-small">Nom de l'objet</label>
|
||||
<label class="label is-small" for="scene-obj-name">Nom de l'objet</label>
|
||||
<div class="control"><input class="input is-small" type="text" id="scene-obj-name" value="{{ obj.name or '' }}" placeholder="ex. Le Sorcier" onchange="saveSceneObjectName({{ obj.id }}, this.value)"></div>
|
||||
</div>
|
||||
</div>
|
||||
@@ -488,22 +489,22 @@
|
||||
<div class="propGroupBody">
|
||||
<div class="columns is-multiline posGrid">
|
||||
<div class="column is-half">
|
||||
<div class="field"><label class="label is-small">X (px)</label>
|
||||
<div class="field"><label class="label is-small" for="scene-pos-x">X (px)</label>
|
||||
<div class="control"><input class="input is-small" type="number" id="scene-pos-x" min="0" value="{{ obj.x }}"></div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="column is-half">
|
||||
<div class="field"><label class="label is-small">Y (px)</label>
|
||||
<div class="field"><label class="label is-small" for="scene-pos-y">Y (px)</label>
|
||||
<div class="control"><input class="input is-small" type="number" id="scene-pos-y" min="0" value="{{ obj.y }}"></div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="column is-half">
|
||||
<div class="field"><label class="label is-small">Largeur (px)</label>
|
||||
<div class="field"><label class="label is-small" for="scene-pos-w">Largeur (px)</label>
|
||||
<div class="control"><input class="input is-small" type="number" id="scene-pos-w" min="1" value="{{ obj.width }}"></div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="column is-half">
|
||||
<div class="field"><label class="label is-small">Hauteur (px)</label>
|
||||
<div class="field"><label class="label is-small" for="scene-pos-h">Hauteur (px)</label>
|
||||
<div class="control"><input class="input is-small" type="number" id="scene-pos-h" min="1" value="{{ obj.height }}"></div>
|
||||
</div>
|
||||
</div>
|
||||
@@ -521,19 +522,19 @@
|
||||
<summary>Style</summary>
|
||||
<div class="propGroupBody" data-element-id="{{ obj.id }}">
|
||||
<div class="field">
|
||||
<label class="label is-small">Police</label>
|
||||
<label class="label is-small" for="dbox-font-family">Police</label>
|
||||
<div class="control">
|
||||
<input class="input is-small" type="text" id="dbox-font-family" value="{{ dialogue_box_style.font_family }}" placeholder="ex. Georgia, serif" onchange="saveDialogueBoxStyle({{ obj.id }})">
|
||||
</div>
|
||||
</div>
|
||||
<div class="columns is-multiline posGrid">
|
||||
<div class="column is-half">
|
||||
<div class="field"><label class="label is-small">Taille (px)</label>
|
||||
<div class="field"><label class="label is-small" for="dbox-font-size">Taille (px)</label>
|
||||
<div class="control"><input class="input is-small" type="number" id="dbox-font-size" min="8" max="48" value="{{ dialogue_box_style.font_size }}" onchange="saveDialogueBoxStyle({{ obj.id }})"></div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="column is-half">
|
||||
<div class="field"><label class="label is-small">Épaisseur</label>
|
||||
<div class="field"><label class="label is-small" for="dbox-font-weight">Épaisseur</label>
|
||||
<div class="control">
|
||||
<select class="input is-small" id="dbox-font-weight" onchange="saveDialogueBoxStyle({{ obj.id }})">
|
||||
{% for w in dialogue_box_font_weight_choices %}
|
||||
@@ -546,22 +547,22 @@
|
||||
</div>
|
||||
<div class="columns is-multiline posGrid">
|
||||
<div class="column is-half">
|
||||
<div class="field"><label class="label is-small">Texte</label>
|
||||
<div class="field"><label class="label is-small" for="dbox-text-color">Texte</label>
|
||||
<div class="control"><input class="input is-small" type="color" id="dbox-text-color" value="{{ dialogue_box_style.text_color }}" onchange="saveDialogueBoxStyle({{ obj.id }})"></div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="column is-half">
|
||||
<div class="field"><label class="label is-small">Header</label>
|
||||
<div class="field"><label class="label is-small" for="dbox-header-bg">Header</label>
|
||||
<div class="control"><input class="input is-small" type="color" id="dbox-header-bg" value="{{ dialogue_box_style.header_bg }}" onchange="saveDialogueBoxStyle({{ obj.id }})"></div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="column is-half">
|
||||
<div class="field"><label class="label is-small">Corps</label>
|
||||
<div class="field"><label class="label is-small" for="dbox-body-bg">Corps</label>
|
||||
<div class="control"><input class="input is-small" type="color" id="dbox-body-bg" value="{{ dialogue_box_style.body_bg }}" onchange="saveDialogueBoxStyle({{ obj.id }})"></div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="column is-half">
|
||||
<div class="field"><label class="label is-small">Pied</label>
|
||||
<div class="field"><label class="label is-small" for="dbox-footer-bg">Pied</label>
|
||||
<div class="control"><input class="input is-small" type="color" id="dbox-footer-bg" value="{{ dialogue_box_style.footer_bg }}" onchange="saveDialogueBoxStyle({{ obj.id }})"></div>
|
||||
</div>
|
||||
</div>
|
||||
@@ -591,7 +592,7 @@
|
||||
Plein écran
|
||||
</label>
|
||||
<div class="field mt-2">
|
||||
<label class="label is-small">Minuteur</label>
|
||||
<label class="label is-small" for="quiz-timer-mode">Minuteur</label>
|
||||
<div class="control">
|
||||
<select class="input is-small" id="quiz-timer-mode" onchange="saveQuizBoxConfig({{ obj.id }})">
|
||||
{% for mode in quiz_box_timer_modes %}
|
||||
@@ -603,7 +604,7 @@
|
||||
</div>
|
||||
</div>
|
||||
<div class="field">
|
||||
<label class="label is-small">Durée (secondes)</label>
|
||||
<label class="label is-small" for="quiz-timer-seconds">Durée (secondes)</label>
|
||||
<div class="control">
|
||||
<input class="input is-small" type="number" id="quiz-timer-seconds" min="3" max="600" value="{{ quiz_box_config.timer_seconds }}" onchange="saveQuizBoxConfig({{ obj.id }})">
|
||||
</div>
|
||||
@@ -690,7 +691,7 @@
|
||||
</label>
|
||||
</div>
|
||||
</div>
|
||||
<div class="field"><label class="label is-small">Forme</label>
|
||||
<div class="field"><label class="label is-small" for="collision-shape">Forme</label>
|
||||
<div class="control">
|
||||
<div class="select is-small">
|
||||
<select id="collision-shape" onchange="saveSceneObjectCollision()">
|
||||
@@ -701,15 +702,15 @@
|
||||
</div>
|
||||
</div>
|
||||
<div class="field is-grouped">
|
||||
<div class="control"><label class="label is-small">Largeur (px)</label>
|
||||
<div class="control"><label class="label is-small" for="collision-width">Largeur (px)</label>
|
||||
<input class="input is-small" type="number" min="1" id="collision-width" value="{{ collision_settings.width }}" onchange="saveSceneObjectCollision()"></div>
|
||||
<div class="control"><label class="label is-small">Hauteur (px)</label>
|
||||
<div class="control"><label class="label is-small" for="collision-height">Hauteur (px)</label>
|
||||
<input class="input is-small" type="number" min="1" id="collision-height" value="{{ collision_settings.height }}" onchange="saveSceneObjectCollision()"></div>
|
||||
</div>
|
||||
<div class="field is-grouped">
|
||||
<div class="control"><label class="label is-small">Décalage X (px)</label>
|
||||
<div class="control"><label class="label is-small" for="collision-offset-x">Décalage X (px)</label>
|
||||
<input class="input is-small" type="number" id="collision-offset-x" value="{{ collision_settings.offset_x }}" onchange="saveSceneObjectCollision()"></div>
|
||||
<div class="control"><label class="label is-small">Décalage Y (px)</label>
|
||||
<div class="control"><label class="label is-small" for="collision-offset-y">Décalage Y (px)</label>
|
||||
<input class="input is-small" type="number" id="collision-offset-y" value="{{ collision_settings.offset_y }}" onchange="saveSceneObjectCollision()"></div>
|
||||
</div>
|
||||
<p class="help">Taille/décalage réglés par rapport au centre de l'objet — laisse la taille par défaut (celle de l'objet) si son image n'a pas de marge inutile.</p>
|
||||
@@ -725,7 +726,7 @@
|
||||
personnage "Joueur" est déplacé/animé automatiquement au
|
||||
clavier et suivi par la caméra — "Ennemi"/"PNJ" restent
|
||||
immobiles tant qu'aucune logique de flow ne les pilote. -->
|
||||
<div class="field"><label class="label is-small">Rôle</label>
|
||||
<div class="field"><label class="label is-small" for="personnage-role">Rôle</label>
|
||||
<div class="control">
|
||||
<div class="select is-small">
|
||||
<select id="personnage-role" onchange="saveSceneObjectRole(this.value)">
|
||||
@@ -769,21 +770,21 @@
|
||||
<div class="propGroupBody" id="personnageCommandsBody" data-element-id="{{ obj.id }}" data-commands-extra='{{ (personnage_commands.extra if personnage_commands else [])|tojson }}'>
|
||||
<p class="help">Ce personnage se déplace et s'anime automatiquement avec ces touches, sans rien à poser dans la logique. Clique un champ puis appuie sur la touche voulue.</p>
|
||||
<div class="field is-grouped">
|
||||
<div class="control"><label class="label is-small">Haut</label>
|
||||
<div class="control"><label class="label is-small" for="cmd-haut">Haut</label>
|
||||
<input class="input is-small personnageKeyCapture" id="cmd-haut" readonly value="{{ personnage_commands.haut }}"></div>
|
||||
<div class="control"><label class="label is-small">Bas</label>
|
||||
<div class="control"><label class="label is-small" for="cmd-bas">Bas</label>
|
||||
<input class="input is-small personnageKeyCapture" id="cmd-bas" readonly value="{{ personnage_commands.bas }}"></div>
|
||||
</div>
|
||||
<div class="field is-grouped">
|
||||
<div class="control"><label class="label is-small">Gauche</label>
|
||||
<div class="control"><label class="label is-small" for="cmd-gauche">Gauche</label>
|
||||
<input class="input is-small personnageKeyCapture" id="cmd-gauche" readonly value="{{ personnage_commands.gauche }}"></div>
|
||||
<div class="control"><label class="label is-small">Droite</label>
|
||||
<div class="control"><label class="label is-small" for="cmd-droite">Droite</label>
|
||||
<input class="input is-small personnageKeyCapture" id="cmd-droite" readonly value="{{ personnage_commands.droite }}"></div>
|
||||
</div>
|
||||
<div class="field"><label class="label is-small">Interagir</label>
|
||||
<div class="field"><label class="label is-small" for="cmd-interagir">Interagir</label>
|
||||
<div class="control"><input class="input is-small personnageKeyCapture" id="cmd-interagir" readonly value="{{ personnage_commands.interagir }}"></div>
|
||||
</div>
|
||||
<div class="field"><label class="label is-small">Axe de déplacement</label>
|
||||
<div class="field"><label class="label is-small" for="cmd-axe">Axe de déplacement</label>
|
||||
<div class="control">
|
||||
<div class="select is-small">
|
||||
<select id="cmd-axe">
|
||||
@@ -794,7 +795,7 @@
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="field"><label class="label is-small">Vitesse (px/tick)</label>
|
||||
<div class="field"><label class="label is-small" for="cmd-vitesse">Vitesse (px/tick)</label>
|
||||
<div class="control"><input class="input is-small" type="number" id="cmd-vitesse" min="1" max="20" value="{{ personnage_commands.vitesse }}"></div>
|
||||
</div>
|
||||
<!-- Touches supplémentaires (sauter, attaquer...) : au-delà des 4
|
||||
|
||||
Reference in New Issue
Block a user