Phase 3 : hardening qualite de code - typage strict, securite, dead code, a11y
Config strictement stricte partout (ruff, mypy --strict, bandit, vulture, import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas casser le build" - l'existant a ete corrige pour la satisfaire plutot que l'inverse. Hooks pre-commit locaux (language: system) bloquants. - Typage mypy --strict propage a tout le moteur (db, screens, auth, core, ai, routes, puis publish/scripts/tests/app.py/build_css.py). - Securite : fuite de handle fichier Windows corrigee dans l'export SCORM (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe "</script>" dans le JSON embarque en <script>, 25 sites). - Architecture : imports circulaires/F811 nettoyes, contrats import-linter respectes, code mort retire (vulture). - Accessibilite : 69 champs de formulaire sans label correctement associe corriges (for/id ou aria-label) sur 11 templates. - ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis appliquees (aucune desactivee sans verification individuelle). - Tests : isolation du compte admin partage (nettoyage ponctuel + fixture de teardown automatique en filet de securite), suite complete verte (591 tests Python, 241 tests JS). - SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport complet analyse point par point, faux positifs documentes. - .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine faisait echouer ESLint (linebreak-style) via un bug connu de git (checkout "en place" qui ignore l'eol force sur un fichier deja present sur disque - contourne en supprimant puis recreant chaque fichier suivi). djLint (H021, styles inline) volontairement saute pour ce commit - backlog assume, deja documente, traite dans un lot separe. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
william
co-authored by
Claude Sonnet 5
Claude Sonnet 5
parent
7db4803b93
commit
c57420c8c9
@@ -5,31 +5,41 @@ screens/labels/background_library.py), derrière tout le reste
|
||||
scène, "monde" que la caméra suit en défilant derrière le personnage
|
||||
(voir static/js/play/personnage-controller.js, testé côté client dans
|
||||
static/js/play/__tests__/personnage-controller.test.js)."""
|
||||
|
||||
import re
|
||||
from collections.abc import Callable
|
||||
from typing import Any
|
||||
|
||||
from flask.testing import FlaskClient
|
||||
|
||||
import screens
|
||||
from tests.conftest import not_none
|
||||
|
||||
|
||||
def _create_jeu2d_game(client, tmp_game_slug_cleanup, name="pytest_background"):
|
||||
def _create_jeu2d_game(
|
||||
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str], name: str = "pytest_background"
|
||||
) -> Any:
|
||||
resp = client.post("/games/new", data={"name": name}, follow_redirects=False)
|
||||
slug = tmp_game_slug_cleanup(resp.headers["Location"].rstrip("/").split("/")[-1])
|
||||
screen_id = screens.create_screen(slug, "Scène 1", kind="jeu_2d")
|
||||
return slug, screen_id
|
||||
|
||||
|
||||
def _a_background_slug():
|
||||
def _a_background_slug() -> Any:
|
||||
assert screens.BACKGROUND_LIBRARY, "aucune image de fond générée — lancer scripts/generate_background_manifest.py"
|
||||
return next(iter(screens.BACKGROUND_LIBRARY))
|
||||
|
||||
|
||||
def test_background_library_is_built_from_the_generated_manifest():
|
||||
def test_background_library_is_built_from_the_generated_manifest() -> None:
|
||||
slug = _a_background_slug()
|
||||
background = screens.BACKGROUND_LIBRARY[slug]
|
||||
assert background["url"].startswith("/static/backgrounds/")
|
||||
assert background["width"] > 0 and background["height"] > 0
|
||||
|
||||
|
||||
def test_adding_a_fond_object_uses_the_image_real_size_and_sits_behind_everything(client, tmp_game_slug_cleanup):
|
||||
def test_adding_a_fond_object_uses_the_image_real_size_and_sits_behind_everything(
|
||||
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
|
||||
) -> None:
|
||||
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
||||
background_slug = _a_background_slug()
|
||||
background = screens.BACKGROUND_LIBRARY[background_slug]
|
||||
@@ -40,9 +50,9 @@ def test_adding_a_fond_object_uses_the_image_real_size_and_sits_behind_everythin
|
||||
follow_redirects=False,
|
||||
)
|
||||
assert resp.status_code == 302, resp.data
|
||||
obj_id = int(re.search(r"selected=(\d+)", resp.headers["Location"]).group(1))
|
||||
obj_id = int(not_none(re.search(r"selected=(\d+)", resp.headers["Location"])).group(1))
|
||||
|
||||
obj = screens.get_scene_object(slug, obj_id)
|
||||
obj = not_none(screens.get_scene_object(slug, obj_id))
|
||||
assert obj["kind"] == "fond"
|
||||
assert obj["width"] == background["width"]
|
||||
assert obj["height"] == background["height"]
|
||||
@@ -51,7 +61,9 @@ def test_adding_a_fond_object_uses_the_image_real_size_and_sits_behind_everythin
|
||||
assert obj["attributes"]["src"] == background["url"]
|
||||
|
||||
|
||||
def test_fond_object_renders_as_an_image_with_the_sceneBackground_class(client, tmp_game_slug_cleanup):
|
||||
def test_fond_object_renders_as_an_image_with_the_sceneBackground_class(
|
||||
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
|
||||
) -> None:
|
||||
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
||||
background_slug = _a_background_slug()
|
||||
resp = client.post(
|
||||
@@ -59,14 +71,16 @@ def test_fond_object_renders_as_an_image_with_the_sceneBackground_class(client,
|
||||
data={"kind": "fond", "background_slug": background_slug},
|
||||
follow_redirects=False,
|
||||
)
|
||||
obj_id = int(re.search(r"selected=(\d+)", resp.headers["Location"]).group(1))
|
||||
obj = screens.get_scene_object(slug, obj_id)
|
||||
obj_id = int(not_none(re.search(r"selected=(\d+)", resp.headers["Location"])).group(1))
|
||||
obj = not_none(screens.get_scene_object(slug, obj_id))
|
||||
html = screens.render_scene_object(obj)
|
||||
assert 'class="sceneObjectSprite sceneBackground"' in html
|
||||
assert f'data-object-id="{obj_id}"' in html
|
||||
|
||||
|
||||
def test_fond_object_falls_back_to_default_size_without_a_known_background_slug(client, tmp_game_slug_cleanup):
|
||||
def test_fond_object_falls_back_to_default_size_without_a_known_background_slug(
|
||||
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
|
||||
) -> None:
|
||||
"""Un slug invalide/absent (URL bidouillée, script de manifeste jamais
|
||||
lancé sur ce poste) : l'objet est quand même créé, à la taille par
|
||||
défaut générique (128x128, voir ensure_scene_schema.py) plutôt que de
|
||||
@@ -78,14 +92,16 @@ def test_fond_object_falls_back_to_default_size_without_a_known_background_slug(
|
||||
follow_redirects=False,
|
||||
)
|
||||
assert resp.status_code == 302
|
||||
obj_id = int(re.search(r"selected=(\d+)", resp.headers["Location"]).group(1))
|
||||
obj = screens.get_scene_object(slug, obj_id)
|
||||
obj_id = int(not_none(re.search(r"selected=(\d+)", resp.headers["Location"])).group(1))
|
||||
obj = not_none(screens.get_scene_object(slug, obj_id))
|
||||
assert obj["width"] == 128 and obj["height"] == 128
|
||||
|
||||
|
||||
def test_background_gallery_route_rejects_a_non_admin_account(user_game, user_client):
|
||||
resp = user_client.post(f"/game/{user_game}/screens/new", data={"name": "Scène", "kind": "jeu_2d"}, follow_redirects=False)
|
||||
screen_id = int(re.search(r"/screens/(\d+)/edit", resp.headers["Location"]).group(1))
|
||||
def test_background_gallery_route_rejects_a_non_admin_account(user_game: str, user_client: FlaskClient) -> None:
|
||||
resp = user_client.post(
|
||||
f"/game/{user_game}/screens/new", data={"name": "Scène", "kind": "jeu_2d"}, follow_redirects=False
|
||||
)
|
||||
screen_id = int(not_none(re.search(r"/screens/(\d+)/edit", resp.headers["Location"])).group(1))
|
||||
background_slug = _a_background_slug()
|
||||
resp = user_client.post(
|
||||
f"/game/{user_game}/screens/{screen_id}/scene-objects/add",
|
||||
@@ -95,8 +111,10 @@ def test_background_gallery_route_rejects_a_non_admin_account(user_game, user_cl
|
||||
assert resp.status_code == 403
|
||||
|
||||
|
||||
def test_background_gallery_hidden_from_non_admin_scene_editor(user_game, user_client):
|
||||
resp = user_client.post(f"/game/{user_game}/screens/new", data={"name": "Scène", "kind": "jeu_2d"}, follow_redirects=False)
|
||||
screen_id = int(re.search(r"/screens/(\d+)/edit", resp.headers["Location"]).group(1))
|
||||
def test_background_gallery_hidden_from_non_admin_scene_editor(user_game: str, user_client: FlaskClient) -> None:
|
||||
resp = user_client.post(
|
||||
f"/game/{user_game}/screens/new", data={"name": "Scène", "kind": "jeu_2d"}, follow_redirects=False
|
||||
)
|
||||
screen_id = int(not_none(re.search(r"/screens/(\d+)/edit", resp.headers["Location"])).group(1))
|
||||
html = user_client.get(f"/game/{user_game}/screens/{screen_id}/edit").get_data(as_text=True)
|
||||
assert "Images de fond" not in html
|
||||
|
||||
Reference in New Issue
Block a user