Phase 3 : hardening qualite de code - typage strict, securite, dead code, a11y
Config strictement stricte partout (ruff, mypy --strict, bandit, vulture, import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas casser le build" - l'existant a ete corrige pour la satisfaire plutot que l'inverse. Hooks pre-commit locaux (language: system) bloquants. - Typage mypy --strict propage a tout le moteur (db, screens, auth, core, ai, routes, puis publish/scripts/tests/app.py/build_css.py). - Securite : fuite de handle fichier Windows corrigee dans l'export SCORM (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe "</script>" dans le JSON embarque en <script>, 25 sites). - Architecture : imports circulaires/F811 nettoyes, contrats import-linter respectes, code mort retire (vulture). - Accessibilite : 69 champs de formulaire sans label correctement associe corriges (for/id ou aria-label) sur 11 templates. - ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis appliquees (aucune desactivee sans verification individuelle). - Tests : isolation du compte admin partage (nettoyage ponctuel + fixture de teardown automatique en filet de securite), suite complete verte (591 tests Python, 241 tests JS). - SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport complet analyse point par point, faux positifs documentes. - .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine faisait echouer ESLint (linebreak-style) via un bug connu de git (checkout "en place" qui ignore l'eol force sur un fichier deja present sur disque - contourne en supprimant puis recreant chaque fichier suivi). djLint (H021, styles inline) volontairement saute pour ce commit - backlog assume, deja documente, traite dans un lot separe. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Sonnet 5
parent
7db4803b93
commit
c57420c8c9
@@ -3,20 +3,24 @@
|
||||
graphe de logique côté client, le comportement RÉEL d'un vrai keydown/
|
||||
setInterval n'est pas testable sans navigateur (voir play_js_bundle() —
|
||||
on vérifie que la logique existe dans le JS livré, pas qu'elle s'exécute)."""
|
||||
|
||||
import json
|
||||
import re
|
||||
from typing import Any
|
||||
|
||||
from conftest import play_js_bundle
|
||||
from conftest import play_js_bundle # type: ignore[import-not-found] # resolu par pytest, pas mypy
|
||||
from flask.testing import FlaskClient
|
||||
|
||||
import screens
|
||||
from tests.conftest import not_none
|
||||
|
||||
|
||||
def _create_screen(client, slug, name="Accueil"):
|
||||
def _create_screen(client: FlaskClient, slug: str, name: str = "Accueil") -> Any:
|
||||
resp = client.post(f"/game/{slug}/screens/new", data={"name": name}, follow_redirects=False)
|
||||
return int(re.search(r"/screens/(\d+)/edit", resp.headers["Location"]).group(1))
|
||||
return int(not_none(re.search(r"/screens/(\d+)/edit", resp.headers["Location"])).group(1))
|
||||
|
||||
|
||||
def _add_flow_node(client, slug, screen_id, **fields):
|
||||
def _add_flow_node(client: FlaskClient, slug: str, screen_id: int, **fields: Any) -> Any:
|
||||
resp = client.post(
|
||||
f"/game/{slug}/screens/{screen_id}/flow/nodes/add",
|
||||
data=json.dumps(fields),
|
||||
@@ -26,37 +30,44 @@ def _add_flow_node(client, slug, screen_id, **fields):
|
||||
return resp.get_json()["id"]
|
||||
|
||||
|
||||
def test_keyboard_trigger_node_persists_key(client, game):
|
||||
def test_keyboard_trigger_node_persists_key(client: FlaskClient, game: str) -> None:
|
||||
screen_id = _create_screen(client, game)
|
||||
node_id = _add_flow_node(client, game, screen_id, node_type="trigger", trigger_event="clavier", trigger_key="ArrowUp")
|
||||
node = screens.get_flow_node(game, node_id)
|
||||
node_id = _add_flow_node(
|
||||
client, game, screen_id, node_type="trigger", trigger_event="clavier", trigger_key="ArrowUp"
|
||||
)
|
||||
node = not_none(screens.get_flow_node(game, node_id))
|
||||
assert node["trigger_event"] == "clavier"
|
||||
assert node["trigger_key"] == "ArrowUp"
|
||||
assert node["trigger_element_id"] is None
|
||||
|
||||
|
||||
def test_keyboard_trigger_persists_space_key(client, game):
|
||||
def test_keyboard_trigger_persists_space_key(client: FlaskClient, game: str) -> None:
|
||||
"""La barre d'espace (ev.key === ' ', un seul caractère espace) ne doit
|
||||
PAS être traitée comme une valeur "vide" par add_flow_node.py (qui
|
||||
filtre None/"" — " " n'est ni l'un ni l'autre) : une touche très
|
||||
probablement utilisée ("Espace pour sauter") doit bien se persister."""
|
||||
screen_id = _create_screen(client, game)
|
||||
node_id = _add_flow_node(client, game, screen_id, node_type="trigger", trigger_event="clavier", trigger_key=" ")
|
||||
node = screens.get_flow_node(game, node_id)
|
||||
node = not_none(screens.get_flow_node(game, node_id))
|
||||
assert node["trigger_key"] == " "
|
||||
|
||||
|
||||
def test_timer_trigger_node_persists_interval(client, game):
|
||||
def test_timer_trigger_node_persists_interval(client: FlaskClient, game: str) -> None:
|
||||
screen_id = _create_screen(client, game)
|
||||
node_id = _add_flow_node(
|
||||
client, game, screen_id, node_type="trigger", trigger_event="minuteur", trigger_interval_ms=500,
|
||||
client,
|
||||
game,
|
||||
screen_id,
|
||||
node_type="trigger",
|
||||
trigger_event="minuteur",
|
||||
trigger_interval_ms=500,
|
||||
)
|
||||
node = screens.get_flow_node(game, node_id)
|
||||
node = not_none(screens.get_flow_node(game, node_id))
|
||||
assert node["trigger_event"] == "minuteur"
|
||||
assert node["trigger_interval_ms"] == 500
|
||||
|
||||
|
||||
def test_play_page_exposes_keyboard_and_timer_trigger_runtime(client, game):
|
||||
def test_play_page_exposes_keyboard_and_timer_trigger_runtime(client: FlaskClient, game: str) -> None:
|
||||
js = play_js_bundle()
|
||||
assert "bindKeyboardTriggers" in js
|
||||
assert "'clavier'" in js
|
||||
|
||||
Reference in New Issue
Block a user