Phase 3 : hardening qualite de code - typage strict, securite, dead code, a11y
Config strictement stricte partout (ruff, mypy --strict, bandit, vulture, import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas casser le build" - l'existant a ete corrige pour la satisfaire plutot que l'inverse. Hooks pre-commit locaux (language: system) bloquants. - Typage mypy --strict propage a tout le moteur (db, screens, auth, core, ai, routes, puis publish/scripts/tests/app.py/build_css.py). - Securite : fuite de handle fichier Windows corrigee dans l'export SCORM (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe "</script>" dans le JSON embarque en <script>, 25 sites). - Architecture : imports circulaires/F811 nettoyes, contrats import-linter respectes, code mort retire (vulture). - Accessibilite : 69 champs de formulaire sans label correctement associe corriges (for/id ou aria-label) sur 11 templates. - ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis appliquees (aucune desactivee sans verification individuelle). - Tests : isolation du compte admin partage (nettoyage ponctuel + fixture de teardown automatique en filet de securite), suite complete verte (591 tests Python, 241 tests JS). - SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport complet analyse point par point, faux positifs documentes. - .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine faisait echouer ESLint (linebreak-style) via un bug connu de git (checkout "en place" qui ignore l'eol force sur un fichier deja present sur disque - contourne en supprimant puis recreant chaque fichier suivi). djLint (H021, styles inline) volontairement saute pour ce commit - backlog assume, deja documente, traite dans un lot separe. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
william
co-authored by
Claude Sonnet 5
Claude Sonnet 5
parent
7db4803b93
commit
c57420c8c9
+44
-29
@@ -6,37 +6,41 @@ joueurs. L'aperçu créateur (PLAYER_SHARED, le défaut de tous les
|
||||
paramètres player_id) doit continuer de fonctionner exactement comme
|
||||
avant ces changements — voir tests/test_confort.py, test_flow.py etc., qui
|
||||
n'ont pas eu besoin d'être modifiés."""
|
||||
|
||||
from flask.testing import FlaskClient
|
||||
|
||||
import db
|
||||
from tests.conftest import not_none
|
||||
|
||||
|
||||
def test_global_variable_per_player_gives_independent_values(game):
|
||||
def test_global_variable_per_player_gives_independent_values(game: str) -> None:
|
||||
db.create_global_variable(game, "score", "nombre_entier", "0", per_player=True)
|
||||
db.update_global_variable_value(game, "score", "10", player_id="alice")
|
||||
db.update_global_variable_value(game, "score", "99", player_id="bob")
|
||||
|
||||
assert db.get_global_variable(game, "score", player_id="alice")["value"] == "10"
|
||||
assert db.get_global_variable(game, "score", player_id="bob")["value"] == "99"
|
||||
assert not_none(db.get_global_variable(game, "score", player_id="alice"))["value"] == "10"
|
||||
assert not_none(db.get_global_variable(game, "score", player_id="bob"))["value"] == "99"
|
||||
# Le créateur (PLAYER_SHARED, la ligne "modèle") garde la valeur par
|
||||
# défaut — jamais écrasée par les joueurs.
|
||||
assert db.get_global_variable(game, "score")["value"] == "0"
|
||||
assert not_none(db.get_global_variable(game, "score"))["value"] == "0"
|
||||
|
||||
|
||||
def test_global_variable_new_player_falls_back_to_default_value(game):
|
||||
def test_global_variable_new_player_falls_back_to_default_value(game: str) -> None:
|
||||
db.create_global_variable(game, "vies", "nombre_entier", "3", per_player=True)
|
||||
assert db.get_global_variable(game, "vies", player_id="charlie")["value"] == "3"
|
||||
assert not_none(db.get_global_variable(game, "vies", player_id="charlie"))["value"] == "3"
|
||||
|
||||
|
||||
def test_global_variable_shared_ignores_player_id(game):
|
||||
def test_global_variable_shared_ignores_player_id(game: str) -> None:
|
||||
db.create_global_variable(game, "compteur_visites", "nombre_entier", "0", per_player=False)
|
||||
db.update_global_variable_value(game, "compteur_visites", "1", player_id="alice")
|
||||
db.update_global_variable_value(game, "compteur_visites", "2", player_id="bob")
|
||||
# Même valeur pour tout le monde, y compris un 3e joueur qui n'a jamais écrit.
|
||||
assert db.get_global_variable(game, "compteur_visites", player_id="alice")["value"] == "2"
|
||||
assert db.get_global_variable(game, "compteur_visites", player_id="bob")["value"] == "2"
|
||||
assert db.get_global_variable(game, "compteur_visites", player_id="charlie")["value"] == "2"
|
||||
assert not_none(db.get_global_variable(game, "compteur_visites", player_id="alice"))["value"] == "2"
|
||||
assert not_none(db.get_global_variable(game, "compteur_visites", player_id="bob"))["value"] == "2"
|
||||
assert not_none(db.get_global_variable(game, "compteur_visites", player_id="charlie"))["value"] == "2"
|
||||
|
||||
|
||||
def test_global_variable_list_only_shows_template_row(game):
|
||||
def test_global_variable_list_only_shows_template_row(game: str) -> None:
|
||||
db.create_global_variable(game, "score", "nombre_entier", "0", per_player=True)
|
||||
db.update_global_variable_value(game, "score", "10", player_id="alice")
|
||||
variables = db.list_global_variables(game)
|
||||
@@ -44,19 +48,19 @@ def test_global_variable_list_only_shows_template_row(game):
|
||||
assert variables[0]["value"] == "0"
|
||||
|
||||
|
||||
def test_global_variable_delete_by_id_cascades_all_players(game):
|
||||
var_id = db.create_global_variable(game, "score", "nombre_entier", "0", per_player=True)
|
||||
def test_global_variable_delete_by_id_cascades_all_players(game: str) -> None:
|
||||
var_id = not_none(db.create_global_variable(game, "score", "nombre_entier", "0", per_player=True))
|
||||
db.update_global_variable_value(game, "score", "10", player_id="alice")
|
||||
db.delete_global_variable_by_id(game, var_id)
|
||||
assert db.get_global_variable(game, "score", player_id="alice") is None
|
||||
assert db.get_global_variable(game, "score") is None
|
||||
|
||||
|
||||
def test_object_per_player_gives_independent_rows(game):
|
||||
def test_object_per_player_gives_independent_rows(game: str) -> None:
|
||||
definition_id = db.create_definition(
|
||||
game, "Inventaire", [{"name": "objet", "type": "texte", "required": False}], per_player=True
|
||||
)
|
||||
definition = db.get_definition(game, definition_id)
|
||||
definition = not_none(db.get_definition(game, definition_id))
|
||||
db.insert_row(game, definition, {"objet": "épée"}, player_id="alice")
|
||||
db.insert_row(game, definition, {"objet": "bouclier"}, player_id="bob")
|
||||
|
||||
@@ -69,11 +73,11 @@ def test_object_per_player_gives_independent_rows(game):
|
||||
assert db.list_rows(game, definition, player_id="charlie") == []
|
||||
|
||||
|
||||
def test_object_shared_gives_same_rows_to_every_player(game):
|
||||
def test_object_shared_gives_same_rows_to_every_player(game: str) -> None:
|
||||
definition_id = db.create_definition(
|
||||
game, "Catalogue", [{"name": "nom", "type": "texte", "required": False}], per_player=False
|
||||
)
|
||||
definition = db.get_definition(game, definition_id)
|
||||
definition = not_none(db.get_definition(game, definition_id))
|
||||
db.insert_row(game, definition, {"nom": "Potion"})
|
||||
alice_rows = db.list_rows(game, definition, player_id="alice")
|
||||
bob_rows = db.list_rows(game, definition, player_id="bob")
|
||||
@@ -81,41 +85,52 @@ def test_object_shared_gives_same_rows_to_every_player(game):
|
||||
assert [r["nom"] for r in bob_rows] == ["Potion"]
|
||||
|
||||
|
||||
def test_get_row_does_not_leak_across_players(game):
|
||||
def test_get_row_does_not_leak_across_players(game: str) -> None:
|
||||
definition_id = db.create_definition(
|
||||
game, "Inventaire", [{"name": "objet", "type": "texte", "required": False}], per_player=True
|
||||
)
|
||||
definition = db.get_definition(game, definition_id)
|
||||
definition = not_none(db.get_definition(game, definition_id))
|
||||
row_id = db.insert_row(game, definition, {"objet": "épée"}, player_id="alice")
|
||||
# Bob ne doit jamais pouvoir lire/modifier/supprimer la ligne d'Alice,
|
||||
# même en devinant son row_id (garde-fou de sécurité pour la route
|
||||
# publique /jouer/<slug>).
|
||||
assert db.get_row(game, definition, row_id, player_id="bob") is None
|
||||
db.update_row_field(game, definition, row_id, definition["fields"][0], "hache", player_id="bob")
|
||||
assert db.get_row(game, definition, row_id, player_id="alice")["objet"] == "épée"
|
||||
assert not_none(db.get_row(game, definition, row_id, player_id="alice"))["objet"] == "épée"
|
||||
db.delete_row(game, definition, row_id, player_id="bob")
|
||||
assert db.get_row(game, definition, row_id, player_id="alice") is not None
|
||||
|
||||
|
||||
def test_create_global_var_route_respects_per_player_checkbox(client, game):
|
||||
client.post(f"/game/{game}/variables/new", data={
|
||||
"name": "score", "type": "nombre_entier", "default_value": "0",
|
||||
})
|
||||
def test_create_global_var_route_respects_per_player_checkbox(client: FlaskClient, game: str) -> None:
|
||||
client.post(
|
||||
f"/game/{game}/variables/new",
|
||||
data={
|
||||
"name": "score",
|
||||
"type": "nombre_entier",
|
||||
"default_value": "0",
|
||||
},
|
||||
)
|
||||
assert db.list_global_variables(game)[0]["per_player"] == 1
|
||||
|
||||
client.post(f"/game/{game}/variables/new", data={
|
||||
"name": "compteur_visites", "type": "nombre_entier", "default_value": "0", "per_player": "0",
|
||||
})
|
||||
client.post(
|
||||
f"/game/{game}/variables/new",
|
||||
data={
|
||||
"name": "compteur_visites",
|
||||
"type": "nombre_entier",
|
||||
"default_value": "0",
|
||||
"per_player": "0",
|
||||
},
|
||||
)
|
||||
variables = {v["name"]: v for v in db.list_global_variables(game)}
|
||||
assert variables["compteur_visites"]["per_player"] == 0
|
||||
|
||||
|
||||
def test_creator_preview_default_matches_shared_definition_behavior(game):
|
||||
def test_creator_preview_default_matches_shared_definition_behavior(game: str) -> None:
|
||||
"""L'aperçu créateur (aucun player_id passé nulle part, donc
|
||||
PLAYER_SHARED partout) doit continuer de fonctionner exactement comme
|
||||
avant l'état par joueur — un seul appelant, un seul jeu de lignes."""
|
||||
definition_id = db.create_definition(game, "Notes", [{"name": "texte", "type": "texte", "required": False}])
|
||||
definition = db.get_definition(game, definition_id)
|
||||
definition = not_none(db.get_definition(game, definition_id))
|
||||
db.insert_row(game, definition, {"texte": "bonjour"})
|
||||
rows = db.list_rows(game, definition)
|
||||
assert [r["texte"] for r in rows] == ["bonjour"]
|
||||
|
||||
Reference in New Issue
Block a user