williamandClaude Sonnet 5
c57420c8c9
Config strictement stricte partout (ruff, mypy --strict, bandit, vulture, import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas casser le build" - l'existant a ete corrige pour la satisfaire plutot que l'inverse. Hooks pre-commit locaux (language: system) bloquants. - Typage mypy --strict propage a tout le moteur (db, screens, auth, core, ai, routes, puis publish/scripts/tests/app.py/build_css.py). - Securite : fuite de handle fichier Windows corrigee dans l'export SCORM (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe "</script>" dans le JSON embarque en <script>, 25 sites). - Architecture : imports circulaires/F811 nettoyes, contrats import-linter respectes, code mort retire (vulture). - Accessibilite : 69 champs de formulaire sans label correctement associe corriges (for/id ou aria-label) sur 11 templates. - ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis appliquees (aucune desactivee sans verification individuelle). - Tests : isolation du compte admin partage (nettoyage ponctuel + fixture de teardown automatique en filet de securite), suite complete verte (591 tests Python, 241 tests JS). - SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport complet analyse point par point, faux positifs documentes. - .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine faisait echouer ESLint (linebreak-style) via un bug connu de git (checkout "en place" qui ignore l'eol force sur un fichier deja present sur disque - contourne en supprimant puis recreant chaque fichier suivi). djLint (H021, styles inline) volontairement saute pour ce commit - backlog assume, deja documente, traite dans un lot separe. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
96 lines
3.6 KiB
Python
96 lines
3.6 KiB
Python
"""Tests unitaires purs de la couche données (db/) — sans passer par Flask."""
|
|
|
|
from collections.abc import Callable
|
|
|
|
import db
|
|
from tests.conftest import not_none
|
|
|
|
|
|
def test_slugify_basic() -> None:
|
|
assert db.slugify("Hello World") == "hello-world"
|
|
assert db.slugify("Île de Ré !!") == "le-de-r"
|
|
assert db.slugify("") == "jeu"
|
|
|
|
|
|
def test_table_name_for() -> None:
|
|
assert db.table_name_for("Personnage Principal") == "obj_personnage_principal"
|
|
|
|
|
|
def test_create_game_and_meta(tmp_game_slug_cleanup: Callable[[str], str]) -> None:
|
|
slug = db.create_game("Mon Jeu De Test")
|
|
tmp_game_slug_cleanup(slug)
|
|
meta = db.game_meta(slug)
|
|
assert meta["name"] == "Mon Jeu De Test"
|
|
|
|
|
|
def test_list_games_only_returns_the_given_owners_projects(tmp_game_slug_cleanup: Callable[[str], str]) -> None:
|
|
"""db.list_games(owner_folder) ne scanne plus jamais projects/ en
|
|
entier (voir routes/games/index.py — faille corrigée : un admin
|
|
voyait auparavant les projets de tous les comptes)."""
|
|
slug = db.create_game("Jeu propriétaire", owner_folder="999999")
|
|
tmp_game_slug_cleanup(slug)
|
|
assert slug in [g["slug"] for g in db.list_games("999999")]
|
|
assert db.list_games("000000") == []
|
|
|
|
|
|
def test_create_game_deduplicates_slug(tmp_game_slug_cleanup: Callable[[str], str]) -> None:
|
|
slug1 = db.create_game("Doublon")
|
|
tmp_game_slug_cleanup(slug1)
|
|
slug2 = db.create_game("Doublon")
|
|
tmp_game_slug_cleanup(slug2)
|
|
assert slug1 != slug2
|
|
|
|
|
|
def test_definition_crud(tmp_game_slug_cleanup: Callable[[str], str]) -> None:
|
|
slug = db.create_game("Objets Test")
|
|
tmp_game_slug_cleanup(slug)
|
|
|
|
definition_id = db.create_definition(
|
|
slug,
|
|
"Personnage",
|
|
[
|
|
{"name": "nom", "type": "texte", "required": True},
|
|
{"name": "pv", "type": "nombre_entier", "required": False},
|
|
],
|
|
)
|
|
definition = not_none(db.get_definition(slug, definition_id))
|
|
assert definition["name"] == "Personnage"
|
|
assert {f["name"] for f in definition["fields"]} == {"nom", "pv"}
|
|
|
|
db.insert_row(slug, definition, {"nom": "Aldric", "pv": "100"})
|
|
rows = db.list_rows(slug, definition)
|
|
assert len(rows) == 1
|
|
assert rows[0]["nom"] == "Aldric"
|
|
assert rows[0]["pv"] == 100
|
|
|
|
row_id = rows[0]["id"]
|
|
db.update_row(slug, definition, row_id, {"nom": "Aldric le Brave", "pv": "80"})
|
|
updated = not_none(db.get_row(slug, definition, row_id))
|
|
assert updated["nom"] == "Aldric le Brave"
|
|
assert updated["pv"] == 80
|
|
|
|
field_def = next(f for f in definition["fields"] if f["name"] == "pv")
|
|
db.update_row_field(slug, definition, row_id, field_def, 42)
|
|
assert not_none(db.get_row(slug, definition, row_id))["pv"] == 42
|
|
# update_row_field ne doit toucher qu'à cette seule colonne
|
|
assert not_none(db.get_row(slug, definition, row_id))["nom"] == "Aldric le Brave"
|
|
|
|
db.delete_row(slug, definition, row_id)
|
|
assert db.list_rows(slug, definition) == []
|
|
|
|
db.delete_definition(slug, definition_id)
|
|
assert db.get_definition(slug, definition_id) is None
|
|
|
|
|
|
def test_relation_blocks_deletion_reference_check(tmp_game_slug_cleanup: Callable[[str], str]) -> None:
|
|
slug = db.create_game("Relations Test")
|
|
tmp_game_slug_cleanup(slug)
|
|
lieu_id = db.create_definition(slug, "Lieu", [{"name": "nom", "type": "texte"}])
|
|
perso_id = db.create_definition(
|
|
slug,
|
|
"Personnage",
|
|
[{"name": "nom", "type": "texte"}, {"name": "lieu", "type": "relation", "relation_definition_id": lieu_id}],
|
|
)
|
|
refs = db.definitions_referencing(slug, lieu_id)
|
|
assert any(r["id"] == perso_id for r in refs)
|