Files
Forge-Engine/tests/test_background_scene_object.py
T
williamandClaude Sonnet 5 c57420c8c9 Phase 3 : hardening qualite de code - typage strict, securite, dead code, a11y
Config strictement stricte partout (ruff, mypy --strict, bandit, vulture,
import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas
casser le build" - l'existant a ete corrige pour la satisfaire plutot que
l'inverse. Hooks pre-commit locaux (language: system) bloquants.

- Typage mypy --strict propage a tout le moteur (db, screens, auth, core,
  ai, routes, puis publish/scripts/tests/app.py/build_css.py).
- Securite : fuite de handle fichier Windows corrigee dans l'export SCORM
  (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes
  (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe
  "</script>" dans le JSON embarque en <script>, 25 sites).
- Architecture : imports circulaires/F811 nettoyes, contrats
  import-linter respectes, code mort retire (vulture).
- Accessibilite : 69 champs de formulaire sans label correctement
  associe corriges (for/id ou aria-label) sur 11 templates.
- ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis
  appliquees (aucune desactivee sans verification individuelle).
- Tests : isolation du compte admin partage (nettoyage ponctuel +
  fixture de teardown automatique en filet de securite), suite complete
  verte (591 tests Python, 241 tests JS).
- SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport
  complet analyse point par point, faux positifs documentes.
- .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine
  faisait echouer ESLint (linebreak-style) via un bug connu de git
  (checkout "en place" qui ignore l'eol force sur un fichier deja
  present sur disque - contourne en supprimant puis recreant chaque
  fichier suivi).

djLint (H021, styles inline) volontairement saute pour ce commit -
backlog assume, deja documente, traite dans un lot separe.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-15 16:06:15 +02:00

121 lines
5.3 KiB
Python

"""Objet de scène kind="fond" (image de fond, voir
screens/scenes/add_scene_object.py) : posé à sa taille RÉELLE (voir
screens/labels/background_library.py), derrière tout le reste
(z_index très négatif), insensible au clic — et si plus grand que la
scène, "monde" que la caméra suit en défilant derrière le personnage
(voir static/js/play/personnage-controller.js, testé côté client dans
static/js/play/__tests__/personnage-controller.test.js)."""
import re
from collections.abc import Callable
from typing import Any
from flask.testing import FlaskClient
import screens
from tests.conftest import not_none
def _create_jeu2d_game(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str], name: str = "pytest_background"
) -> Any:
resp = client.post("/games/new", data={"name": name}, follow_redirects=False)
slug = tmp_game_slug_cleanup(resp.headers["Location"].rstrip("/").split("/")[-1])
screen_id = screens.create_screen(slug, "Scène 1", kind="jeu_2d")
return slug, screen_id
def _a_background_slug() -> Any:
assert screens.BACKGROUND_LIBRARY, "aucune image de fond générée — lancer scripts/generate_background_manifest.py"
return next(iter(screens.BACKGROUND_LIBRARY))
def test_background_library_is_built_from_the_generated_manifest() -> None:
slug = _a_background_slug()
background = screens.BACKGROUND_LIBRARY[slug]
assert background["url"].startswith("/static/backgrounds/")
assert background["width"] > 0 and background["height"] > 0
def test_adding_a_fond_object_uses_the_image_real_size_and_sits_behind_everything(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
background_slug = _a_background_slug()
background = screens.BACKGROUND_LIBRARY[background_slug]
resp = client.post(
f"/game/{slug}/screens/{screen_id}/scene-objects/add",
data={"kind": "fond", "background_slug": background_slug},
follow_redirects=False,
)
assert resp.status_code == 302, resp.data
obj_id = int(not_none(re.search(r"selected=(\d+)", resp.headers["Location"])).group(1))
obj = not_none(screens.get_scene_object(slug, obj_id))
assert obj["kind"] == "fond"
assert obj["width"] == background["width"]
assert obj["height"] == background["height"]
assert obj["x"] == 0 and obj["y"] == 0
assert obj["z_index"] < 0 # toujours derrière un personnage/décor ajouté normalement (z_index >= 1)
assert obj["attributes"]["src"] == background["url"]
def test_fond_object_renders_as_an_image_with_the_sceneBackground_class(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
background_slug = _a_background_slug()
resp = client.post(
f"/game/{slug}/screens/{screen_id}/scene-objects/add",
data={"kind": "fond", "background_slug": background_slug},
follow_redirects=False,
)
obj_id = int(not_none(re.search(r"selected=(\d+)", resp.headers["Location"])).group(1))
obj = not_none(screens.get_scene_object(slug, obj_id))
html = screens.render_scene_object(obj)
assert 'class="sceneObjectSprite sceneBackground"' in html
assert f'data-object-id="{obj_id}"' in html
def test_fond_object_falls_back_to_default_size_without_a_known_background_slug(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
"""Un slug invalide/absent (URL bidouillée, script de manifeste jamais
lancé sur ce poste) : l'objet est quand même créé, à la taille par
défaut générique (128x128, voir ensure_scene_schema.py) plutôt que de
planter."""
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
resp = client.post(
f"/game/{slug}/screens/{screen_id}/scene-objects/add",
data={"kind": "fond", "background_slug": "ce-slug-nexiste-pas"},
follow_redirects=False,
)
assert resp.status_code == 302
obj_id = int(not_none(re.search(r"selected=(\d+)", resp.headers["Location"])).group(1))
obj = not_none(screens.get_scene_object(slug, obj_id))
assert obj["width"] == 128 and obj["height"] == 128
def test_background_gallery_route_rejects_a_non_admin_account(user_game: str, user_client: FlaskClient) -> None:
resp = user_client.post(
f"/game/{user_game}/screens/new", data={"name": "Scène", "kind": "jeu_2d"}, follow_redirects=False
)
screen_id = int(not_none(re.search(r"/screens/(\d+)/edit", resp.headers["Location"])).group(1))
background_slug = _a_background_slug()
resp = user_client.post(
f"/game/{user_game}/screens/{screen_id}/scene-objects/add",
data={"kind": "fond", "background_slug": background_slug},
follow_redirects=False,
)
assert resp.status_code == 403
def test_background_gallery_hidden_from_non_admin_scene_editor(user_game: str, user_client: FlaskClient) -> None:
resp = user_client.post(
f"/game/{user_game}/screens/new", data={"name": "Scène", "kind": "jeu_2d"}, follow_redirects=False
)
screen_id = int(not_none(re.search(r"/screens/(\d+)/edit", resp.headers["Location"])).group(1))
html = user_client.get(f"/game/{user_game}/screens/{screen_id}/edit").get_data(as_text=True)
assert "Images de fond" not in html