williamandClaude Sonnet 5
c57420c8c9
Config strictement stricte partout (ruff, mypy --strict, bandit, vulture, import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas casser le build" - l'existant a ete corrige pour la satisfaire plutot que l'inverse. Hooks pre-commit locaux (language: system) bloquants. - Typage mypy --strict propage a tout le moteur (db, screens, auth, core, ai, routes, puis publish/scripts/tests/app.py/build_css.py). - Securite : fuite de handle fichier Windows corrigee dans l'export SCORM (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe "</script>" dans le JSON embarque en <script>, 25 sites). - Architecture : imports circulaires/F811 nettoyes, contrats import-linter respectes, code mort retire (vulture). - Accessibilite : 69 champs de formulaire sans label correctement associe corriges (for/id ou aria-label) sur 11 templates. - ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis appliquees (aucune desactivee sans verification individuelle). - Tests : isolation du compte admin partage (nettoyage ponctuel + fixture de teardown automatique en filet de securite), suite complete verte (591 tests Python, 241 tests JS). - SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport complet analyse point par point, faux positifs documentes. - .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine faisait echouer ESLint (linebreak-style) via un bug connu de git (checkout "en place" qui ignore l'eol force sur un fichier deja present sur disque - contourne en supprimant puis recreant chaque fichier suivi). djLint (H021, styles inline) volontairement saute pour ce commit - backlog assume, deja documente, traite dans un lot separe. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
65 lines
2.6 KiB
Python
65 lines
2.6 KiB
Python
"""Suppression d'un objet de scène en AJAX (voir routes/scenes/
|
|
scene_object_delete.py, deleteSceneObject() dans static/js/scenes/
|
|
scene-editor.js) : même principe que l'ajout (test_scene_object_add_ajax.py)
|
|
— une réponse JSON quand l'appelant envoie X-Requested-With: fetch, pour
|
|
ne plus "vider" l'éditeur de collision/quêtes le temps d'un remplacement
|
|
de <main> par pjax.js (qui interceptait la soumission du formulaire de
|
|
suppression classique)."""
|
|
|
|
from collections.abc import Callable
|
|
from typing import Any
|
|
|
|
from flask.testing import FlaskClient
|
|
|
|
import screens
|
|
|
|
|
|
def _create_jeu2d_game(
|
|
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str], name: str = "pytest_delete_ajax"
|
|
) -> Any:
|
|
resp = client.post("/games/new", data={"name": name}, follow_redirects=False)
|
|
slug = tmp_game_slug_cleanup(resp.headers["Location"].rstrip("/").split("/")[-1])
|
|
screen_id = screens.create_screen(slug, "Scène 1", kind="jeu_2d")
|
|
return slug, screen_id
|
|
|
|
|
|
def _add_ajax(client: FlaskClient, slug: str, screen_id: int, **data: Any) -> Any:
|
|
return client.post(
|
|
f"/game/{slug}/screens/{screen_id}/scene-objects/add",
|
|
data=data,
|
|
headers={"X-Requested-With": "fetch"},
|
|
).get_json()
|
|
|
|
|
|
def test_ajax_delete_returns_json_and_removes_the_object(
|
|
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
|
|
) -> None:
|
|
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
|
obj_id = _add_ajax(client, slug, screen_id, kind="personnage")["id"]
|
|
|
|
resp = client.post(
|
|
f"/game/{slug}/scene-objects/{obj_id}/delete",
|
|
headers={"X-Requested-With": "fetch"},
|
|
)
|
|
assert resp.status_code == 200
|
|
assert resp.get_json() == {"ok": True, "id": obj_id}
|
|
assert screens.get_scene_object(slug, obj_id) is None
|
|
|
|
|
|
def test_ajax_delete_404s_for_missing_object(client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]) -> None:
|
|
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
|
resp = client.post(
|
|
f"/game/{slug}/scene-objects/999999/delete",
|
|
headers={"X-Requested-With": "fetch"},
|
|
)
|
|
assert resp.status_code == 404
|
|
assert resp.get_json() == {"ok": False}
|
|
|
|
|
|
def test_non_ajax_delete_still_redirects(client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]) -> None:
|
|
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
|
obj_id = _add_ajax(client, slug, screen_id, kind="personnage")["id"]
|
|
resp = client.post(f"/game/{slug}/scene-objects/{obj_id}/delete", follow_redirects=False)
|
|
assert resp.status_code == 302
|
|
assert screens.get_scene_object(slug, obj_id) is None
|