williamandClaude Sonnet 5
ecd483f352
Build and deploy / test-python (push) Successful in 7m48s
Build and deploy / test-js (push) Successful in 52s
Build and deploy / lint-python (push) Successful in 5m44s
Build and deploy / lint-js (push) Failing after 1m52s
Build and deploy / build-and-push (push) Skipped
Build and deploy / deploy (push) Skipped
Build and deploy / sonarqube (push) Failing after 5m5s
Retour utilisateur : "il faut implementer un systeme de page". Un support est desormais compose de PLUSIEURS pages (_document_pages), chacune un document independant affiche seul sur le canevas -- chaque element appartient a exactement une page via page_id (document_engine/ elements/*, routes/document/document_element_add.py/document_render.py revalident desormais un page_id explicite). Migration automatique et silencieuse pour les supports crees avant cette fonctionnalite (db/supports/ensure_document_pages_schema.py, meme convention que les ensure_X_schema.py existants) : leurs elements deviennent tous les enfants d'une "Page 1" creee a la volee, aucune perte de contenu. Nouveau paquet document_engine/pages/ (add/list/get/rename/move/delete) et 4 routes dediees (routes/document/document_page_*.py) -- supprimer la DERNIERE page restante est refuse (garde-fou pose a la route, meme decoupage que routes/game/screens/screen_delete.py cote jeu, jamais dans la fonction bas niveau). Cote editeur : une bande d'ONGLETS au-dessus du canevas (jamais un panneau lateral, choix explicite de l'utilisateur) -- clic pour changer de page, double-clic pour renommer (contenteditable), glisser pour reordonner, "+" pour ajouter, "x" pour supprimer. Changer de page vide la pile Annuler/Retablir (une commande empilee sur une autre page n'a plus de sens). Mode Apercu : navigation Page precedente/suivante avec indicateur "Page X / N" (choix explicite : page par page, pas de defilement continu), jamais affichee s'il n'y a qu'une seule page. Verifie : suite pytest complete (702 tests, dont 14 nouveaux pour les routes de pages), simulation DOM reelle (jsdom, 25 assertions couvrant tout le cycle de vie cote client -- creation/bascule/renommage/ reordonnancement/suppression de page, portee correcte des elements par page, pile Annuler/Retablir videe au changement de page, pilule de navigation en Apercu), et un test de fumee HTTP reel contre le serveur de dev en marche (creation/ajout d'element/rendu/renommage/suppression d'une page, refus de supprimer la derniere page, page inconnue -> 404). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
96 lines
4.3 KiB
Python
96 lines
4.3 KiB
Python
"""Routes HTTP des pages d'un support de formation (routes/document/
|
|
document_page_*.py) — retour utilisateur du 21/09/2026 : "il faut
|
|
implémenter un système de page". Un support a toujours au moins une page
|
|
(créée par défaut avec le support, voir la fixture `support`)."""
|
|
|
|
from flask.testing import FlaskClient
|
|
|
|
import document_engine
|
|
|
|
|
|
def _page_id(support: str) -> int:
|
|
return int(document_engine.list_document_pages(support)[0]["id"])
|
|
|
|
|
|
def test_document_page_add_creates_a_second_page(client: FlaskClient, support: str) -> None:
|
|
resp = client.post(f"/document/{support}/pages/add", json={})
|
|
assert resp.status_code == 200
|
|
payload = resp.get_json()
|
|
assert payload["title"] == "Page 2"
|
|
|
|
pages = document_engine.list_document_pages(support)
|
|
assert [p["title"] for p in pages] == ["Page 1", "Page 2"]
|
|
assert pages[1]["id"] == payload["id"]
|
|
|
|
|
|
def test_document_page_add_accepts_a_custom_title(client: FlaskClient, support: str) -> None:
|
|
resp = client.post(f"/document/{support}/pages/add", json={"title": "Chapitre 2"})
|
|
assert resp.status_code == 200
|
|
assert resp.get_json()["title"] == "Chapitre 2"
|
|
|
|
|
|
def test_document_page_rename_persists_the_new_title(client: FlaskClient, support: str) -> None:
|
|
page_id = _page_id(support)
|
|
resp = client.post(f"/document/{support}/pages/{page_id}/rename", json={"title": "Introduction"})
|
|
assert resp.status_code == 200
|
|
assert resp.get_json() == {"ok": True, "title": "Introduction"}
|
|
page = document_engine.get_document_page(support, page_id)
|
|
assert page is not None
|
|
assert page["title"] == "Introduction"
|
|
|
|
|
|
def test_document_page_rename_ignores_an_empty_title(client: FlaskClient, support: str) -> None:
|
|
page_id = _page_id(support)
|
|
resp = client.post(f"/document/{support}/pages/{page_id}/rename", json={"title": " "})
|
|
assert resp.status_code == 200
|
|
assert resp.get_json()["title"] == "Page 1"
|
|
|
|
|
|
def test_document_page_rename_rejects_an_unknown_page(client: FlaskClient, support: str) -> None:
|
|
assert client.post(f"/document/{support}/pages/999/rename", json={"title": "X"}).status_code == 404
|
|
|
|
|
|
def test_document_page_delete_refuses_the_last_remaining_page(client: FlaskClient, support: str) -> None:
|
|
page_id = _page_id(support)
|
|
resp = client.post(f"/document/{support}/pages/{page_id}/delete")
|
|
assert resp.status_code == 400
|
|
assert "error" in resp.get_json()
|
|
assert document_engine.get_document_page(support, page_id) is not None
|
|
|
|
|
|
def test_document_page_delete_removes_a_non_last_page_and_its_elements(client: FlaskClient, support: str) -> None:
|
|
first_page_id = _page_id(support)
|
|
second_page_id = client.post(f"/document/{support}/pages/add", json={}).get_json()["id"]
|
|
element_resp = client.post(f"/document/{support}/elements/add", data={"kind": "titre", "page_id": second_page_id})
|
|
element_id = element_resp.get_json()["id"]
|
|
|
|
resp = client.post(f"/document/{support}/pages/{second_page_id}/delete")
|
|
assert resp.status_code == 200
|
|
assert resp.get_json()["ok"] is True
|
|
|
|
assert document_engine.get_document_page(support, second_page_id) is None
|
|
assert document_engine.get_document_element(support, element_id) is None
|
|
assert [p["id"] for p in document_engine.list_document_pages(support)] == [first_page_id]
|
|
|
|
|
|
def test_document_page_delete_rejects_an_unknown_page(client: FlaskClient, support: str) -> None:
|
|
client.post(f"/document/{support}/pages/add", json={})
|
|
assert client.post(f"/document/{support}/pages/999/delete").status_code == 404
|
|
|
|
|
|
def test_document_page_move_reorders_the_tab_strip(client: FlaskClient, support: str) -> None:
|
|
first_page_id = _page_id(support)
|
|
second_page_id = client.post(f"/document/{support}/pages/add", json={}).get_json()["id"]
|
|
third_page_id = client.post(f"/document/{support}/pages/add", json={}).get_json()["id"]
|
|
|
|
resp = client.post(f"/document/{support}/pages/{third_page_id}/move", json={"new_index": 0})
|
|
assert resp.status_code == 200
|
|
assert resp.get_json()["ok"] is True
|
|
|
|
ordered_ids = [p["id"] for p in document_engine.list_document_pages(support)]
|
|
assert ordered_ids == [third_page_id, first_page_id, second_page_id]
|
|
|
|
|
|
def test_document_page_move_rejects_an_unknown_page(client: FlaskClient, support: str) -> None:
|
|
assert client.post(f"/document/{support}/pages/999/move", json={"new_index": 0}).status_code == 404
|