williamandClaude Sonnet 5
b2e933f322
Build and deploy / test-python (push) Successful in 11m12s
Build and deploy / test-js (push) Successful in 53s
Build and deploy / lint-python (push) Successful in 3m56s
Build and deploy / lint-js (push) Successful in 3m1s
Build and deploy / build-and-push (push) Skipped
Build and deploy / deploy (push) Skipped
Build and deploy / sonarqube (push) Failing after 3m58s
Prepare la scission a venir entre l'editeur Jeu 2D et le futur editeur Support de formation (voir docs/plan/PLAN.md), sans toucher a l'architecture en couches existante : - screens/ renomme en game_engine/ (nom clair pour le moteur du jeu 2D, avant l'arrivee d'un second "moteur" cote document) : ~85 imports corriges, contrat import-linter mis a jour, meme forme de couches. - routes/, scripts/, static/, templates/, tests/ : tout ce qui est propre au jeu 2D deplace dans un sous-dossier game/ de chacun (routes/game/, static/game/, templates/game/, tests/game/, scripts/game/) ; ce qui est partage par le site (auth, onboarding, dashboard, uploads, db/) reste a la racine de chaque dossier. Un sous-dossier document/ (vide) cree dans chacun pour le futur chantier. - styles/ volontairement inchange : les 3 fichiers sources sont concatenes en un seul static/style.css charge par tout le site, scinder leur CONTENU (editeur vs partage) serait un refactor CSS distinct, pas un deplacement mecanique. - Chaine d'export SCORM (publish/build_scorm_package.py) mise a jour en profondeur : copie des assets, URLs d'icones relatives a static/style.css (qui ne bouge pas), manifeste, wrapper SCORM. - Deux regressions d'un sweep de renommage anterieur corrigees au passage (screens.js/screens/scene-objects incorrectement convertis en game_engine.js/game_engine/scene-objects dans des commentaires). - Effet de bord Windows decouvert et corrige : git mv + Path.write_text convertissent des fichiers en CRLF (core.autocrlf=true) - ~189 fichiers normalises en LF. - .eslintrc.json/package.json : uniquement les chemins de glob mis a jour (static/game/js/...) ; la preparation eslint-plugin-unicorn du lot 7 reste volontairement non committee (package-lock.json restaure a la version precedente). Verifications : ruff, mypy --strict (391 fichiers), vulture, bandit, lint-imports tous verts ; 591/591 tests Python, 276/276 tests JS ; demarrage serveur + requetes HTTP manuelles confirmant que les assets deplaces repondent en 200 au nouvel emplacement et 404 a l'ancien. SKIP=djlint : backlog H021 (styles inline) deja documente comme dette assumee dans CODE_QUALITY.md section 6, aucun template touche par ce commit au-dela d'un deplacement de fichier. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
146 lines
6.6 KiB
Python
146 lines
6.6 KiB
Python
"""Onglet "Générer avec l'IA" — plusieurs CONVERSATIONS par écran (CRUD,
|
|
comme claude.ai, voir plan) : routes/game/ia/ia_chat.py + game_engine/ia/.
|
|
ANTHROPIC_API_KEY est toujours absente en test (voir tests/conftest.py) :
|
|
ces tests exercent donc le chemin de DÉGRADATION GRACIEUSE (message
|
|
d'erreur clair, jamais une 500) pour l'envoi de message — pas un appel
|
|
réel, quel que soit le .env local du poste."""
|
|
|
|
from collections.abc import Callable
|
|
from typing import Any
|
|
|
|
from flask.testing import FlaskClient
|
|
|
|
import game_engine
|
|
|
|
|
|
def _create_jeu2d_game(
|
|
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str], name: str = "pytest_ia_chat"
|
|
) -> Any:
|
|
resp = client.post("/games/new", data={"name": name}, follow_redirects=False)
|
|
slug = tmp_game_slug_cleanup(resp.headers["Location"].rstrip("/").split("/")[-1])
|
|
screen_id = game_engine.create_screen(slug, "Scène 1", kind="jeu_2d")
|
|
return slug, screen_id
|
|
|
|
|
|
def test_create_and_list_conversations(client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]) -> None:
|
|
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
|
resp = client.post(f"/game/{slug}/screens/{screen_id}/ia-conversations")
|
|
assert resp.status_code == 200
|
|
conversation = resp.get_json()
|
|
assert conversation["title"] == "Nouvelle conversation"
|
|
|
|
resp2 = client.get(f"/game/{slug}/screens/{screen_id}/ia-conversations")
|
|
assert resp2.status_code == 200
|
|
ids = [c["id"] for c in resp2.get_json()]
|
|
assert conversation["id"] in ids
|
|
|
|
|
|
def test_conversations_are_isolated_per_screen(
|
|
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
|
|
) -> None:
|
|
slug, screen_id_1 = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
|
screen_id_2 = game_engine.create_screen(slug, "Scène 2", kind="jeu_2d")
|
|
client.post(f"/game/{slug}/screens/{screen_id_1}/ia-conversations")
|
|
|
|
resp = client.get(f"/game/{slug}/screens/{screen_id_2}/ia-conversations")
|
|
assert resp.get_json() == []
|
|
|
|
|
|
def test_delete_conversation_removes_it_from_the_list(
|
|
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
|
|
) -> None:
|
|
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
|
conversation = client.post(f"/game/{slug}/screens/{screen_id}/ia-conversations").get_json()
|
|
|
|
resp = client.delete(f"/game/{slug}/ia-conversations/{conversation['id']}")
|
|
assert resp.status_code == 200
|
|
|
|
remaining = client.get(f"/game/{slug}/screens/{screen_id}/ia-conversations").get_json()
|
|
assert all(c["id"] != conversation["id"] for c in remaining)
|
|
|
|
|
|
def test_delete_unknown_conversation_404s(client: FlaskClient, game: str) -> None:
|
|
resp = client.delete(f"/game/{game}/ia-conversations/999999")
|
|
assert resp.status_code == 404
|
|
|
|
|
|
def test_send_message_persists_it_and_a_graceful_error_reply(
|
|
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
|
|
) -> None:
|
|
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
|
conversation = client.post(f"/game/{slug}/screens/{screen_id}/ia-conversations").get_json()
|
|
|
|
resp = client.post(
|
|
f"/game/{slug}/ia-conversations/{conversation['id']}/messages", json={"message": "Génère un dialogue"}
|
|
)
|
|
assert resp.status_code == 200
|
|
body = resp.get_json()
|
|
assert body["user_message"]["content"] == "Génère un dialogue"
|
|
assert body["user_message"]["role"] == "user"
|
|
assert body["assistant_message"]["role"] == "assistant"
|
|
assert "Configuration IA incomplète" in body["assistant_message"]["content"]
|
|
|
|
|
|
def test_send_message_rejects_an_empty_message(
|
|
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
|
|
) -> None:
|
|
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
|
conversation = client.post(f"/game/{slug}/screens/{screen_id}/ia-conversations").get_json()
|
|
resp = client.post(f"/game/{slug}/ia-conversations/{conversation['id']}/messages", json={"message": " "})
|
|
assert resp.status_code == 400
|
|
|
|
|
|
def test_send_message_404s_for_an_unknown_conversation(client: FlaskClient, game: str) -> None:
|
|
resp = client.post(f"/game/{game}/ia-conversations/999999/messages", json={"message": "salut"})
|
|
assert resp.status_code == 404
|
|
|
|
|
|
def test_messages_history_is_persisted_and_ordered(
|
|
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
|
|
) -> None:
|
|
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
|
conversation = client.post(f"/game/{slug}/screens/{screen_id}/ia-conversations").get_json()
|
|
|
|
client.post(f"/game/{slug}/ia-conversations/{conversation['id']}/messages", json={"message": "premier"})
|
|
client.post(f"/game/{slug}/ia-conversations/{conversation['id']}/messages", json={"message": "second"})
|
|
|
|
resp = client.get(f"/game/{slug}/ia-conversations/{conversation['id']}/messages")
|
|
assert resp.status_code == 200
|
|
messages = resp.get_json()
|
|
user_contents = [m["content"] for m in messages if m["role"] == "user"]
|
|
assert user_contents == ["premier", "second"]
|
|
|
|
|
|
def test_messages_are_isolated_per_conversation(
|
|
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
|
|
) -> None:
|
|
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
|
conversation_1 = client.post(f"/game/{slug}/screens/{screen_id}/ia-conversations").get_json()
|
|
conversation_2 = client.post(f"/game/{slug}/screens/{screen_id}/ia-conversations").get_json()
|
|
|
|
client.post(f"/game/{slug}/ia-conversations/{conversation_1['id']}/messages", json={"message": "pour la 1ère"})
|
|
|
|
resp = client.get(f"/game/{slug}/ia-conversations/{conversation_2['id']}/messages")
|
|
assert resp.get_json() == []
|
|
|
|
|
|
def test_first_user_message_renames_the_conversation(
|
|
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
|
|
) -> None:
|
|
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
|
|
conversation = client.post(f"/game/{slug}/screens/{screen_id}/ia-conversations").get_json()
|
|
|
|
client.post(
|
|
f"/game/{slug}/ia-conversations/{conversation['id']}/messages", json={"message": "Crée un fond de bureau"}
|
|
)
|
|
|
|
conversations = client.get(f"/game/{slug}/screens/{screen_id}/ia-conversations").get_json()
|
|
updated = next(c for c in conversations if c["id"] == conversation["id"])
|
|
assert updated["title"] == "Crée un fond de bureau"
|
|
|
|
# Un deuxième message ne renomme plus (titre déjà dérivé du premier).
|
|
client.post(f"/game/{slug}/ia-conversations/{conversation['id']}/messages", json={"message": "et une variable"})
|
|
conversations2 = client.get(f"/game/{slug}/screens/{screen_id}/ia-conversations").get_json()
|
|
updated2 = next(c for c in conversations2 if c["id"] == conversation["id"])
|
|
assert updated2["title"] == "Crée un fond de bureau"
|