Forge-Store/Forge-Engine
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects 1 Releases Wiki Activity
Files
3260cde122affb123858efe525fd2b2b138b4e34
Forge-Engine/tests/test_screen_triggers.py
T
williamandClaude Sonnet 5 c57420c8c9 Phase 3 : hardening qualite de code - typage strict, securite, dead code, a11y 
Config strictement stricte partout (ruff, mypy --strict, bandit, vulture,
import-linter, eslint, stylelint), aucune regle desactivee "pour ne pas
casser le build" - l'existant a ete corrige pour la satisfaire plutot que
l'inverse. Hooks pre-commit locaux (language: system) bloquants.

- Typage mypy --strict propage a tout le moteur (db, screens, auth, core,
  ai, routes, puis publish/scripts/tests/app.py/build_css.py).
- Securite : fuite de handle fichier Windows corrigee dans l'export SCORM
  (routes/publish/export_scorm.py), CSRF/RNG non-crypto/xAPI documentes
  (# nosec, # NOSONAR justifies), nouveau db.json_for_script() (echappe
  "</script>" dans le JSON embarque en <script>, 25 sites).
- Architecture : imports circulaires/F811 nettoyes, contrats
  import-linter respectes, code mort retire (vulture).
- Accessibilite : 69 champs de formulaire sans label correctement
  associe corriges (for/id ou aria-label) sur 11 templates.
- ESLint/Stylelint : lot mecanique JS/CSS, regles ajustees puis
  appliquees (aucune desactivee sans verification individuelle).
- Tests : isolation du compte admin partage (nettoyage ponctuel +
  fixture de teardown automatique en filet de securite), suite complete
  verte (591 tests Python, 241 tests JS).
- SonarQube Community Build self-heberge (Docker + PostgreSQL) : rapport
  complet analyse point par point, faux positifs documentes.
- .gitattributes ajoute (LF force) : core.autocrlf=true sur cette machine
  faisait echouer ESLint (linebreak-style) via un bug connu de git
  (checkout "en place" qui ignore l'eol force sur un fichier deja
  present sur disque - contourne en supprimant puis recreant chaque
  fichier suivi).

djLint (H021, styles inline) volontairement saute pour ce commit -
backlog assume, deja documente, traite dans un lot separe.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-15 16:06:15 +02:00

387 lines
14 KiB
Python
Raw Blame History

"""Déclencheurs D'ÉCRAN (voir screens/rendering/screen_triggers.py) : une
règle "déclencheur (affichage) -> action" posée sur un ÉCRAN plutôt que
sur un objet — SANS objet requis, pour de la narration/cinématique dès
l'affichage. Section "Déclencheurs de l'écran" de l'éditeur de scène."""
from collections.abc import Callable
from typing import Any
from flask.testing import FlaskClient
import screens
def _create_jeu2d_game(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str], name: str = "pytest_screen_triggers"
) -> Any:
resp = client.post("/games/new", data={"name": name}, follow_redirects=False)
slug = tmp_game_slug_cleanup(resp.headers["Location"].rstrip("/").split("/")[-1])
screen_id = screens.create_screen(slug, "Scène 1", kind="jeu_2d")
return slug, screen_id
def test_freshly_created_screen_has_no_screen_triggers(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screen = screens.get_screen(slug, screen_id)
assert screens.resolve_screen_triggers(screen) == []
def test_sanitize_screen_triggers_keeps_an_affichage_trigger() -> None:
rules = screens.sanitize_screen_triggers(
[
{"trigger": "affichage", "action": {"type": "dialogue"}},
]
)
assert rules == [{"trigger": "affichage", "action": {"type": "dialogue"}}]
def test_sanitize_screen_triggers_rejects_triggers_not_allowed_at_screen_level() -> None:
"""Un déclencheur d'OBJET ("collision"/"clic"/"survol") n'a pas de
sens sans objet — seul "affichage" est autorisé pour un déclencheur
d'écran (voir TRIGGER_TYPES_SCREEN)."""
rules = screens.sanitize_screen_triggers(
[
{"trigger": "collision", "action": {"type": "dialogue"}},
{"trigger": "clic", "action": {"type": "dialogue"}},
{"trigger": "survol", "action": {"type": "dialogue"}},
]
)
assert rules == []
def test_sanitize_screen_triggers_keeps_a_video_action() -> None:
rules = screens.sanitize_screen_triggers(
[
{
"trigger": "affichage",
"action": {"type": "video", "asset_url": "/assets/1/intro.mp4", "mode": "plein_ecran"},
}
]
)
assert rules == [
{
"trigger": "affichage",
"action": {"type": "video", "asset_url": "/assets/1/intro.mp4", "mode": "plein_ecran"},
}
]
def test_sanitize_screen_triggers_keeps_an_attendre_then_dialogue_chain() -> None:
"""Cas d'usage demandé : "à l'affichage de l'écran" -> attendre N
secondes -> déclencher un dialogue."""
rules = screens.sanitize_screen_triggers(
[
{
"trigger": "affichage",
"action": {
"type": "attendre",
"data_value": "3",
"then": {"type": "dialogue", "dialogue": {"id": "d_1", "lines": []}},
},
}
]
)
assert rules[0]["action"]["type"] == "attendre"
assert rules[0]["action"]["then"]["type"] == "dialogue"
def test_set_screen_triggers_persists_and_resolve_reads_it_back(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(slug, screen_id, [{"trigger": "affichage", "action": {"type": "dialogue"}}])
screen = screens.get_screen(slug, screen_id)
assert screens.resolve_screen_triggers(screen) == [{"trigger": "affichage", "action": {"type": "dialogue"}}]
def test_screen_triggers_are_isolated_between_screens(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id_1 = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screen_id_2 = screens.create_screen(slug, "Scène 2", kind="jeu_2d")
screens.set_screen_triggers(slug, screen_id_1, [{"trigger": "affichage", "action": {"type": "dialogue"}}])
screen_2 = screens.get_screen(slug, screen_id_2)
assert screens.resolve_screen_triggers(screen_2) == []
def test_append_action_to_screen_trigger_attaches_a_leaf_at_the_end_of_the_chain(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(
slug,
screen_id,
[
{
"trigger": "affichage",
"action": {"type": "dialogue", "dialogue": {"id": "d_1", "lines": []}},
}
],
)
ok = screens.append_action_to_screen_trigger(
slug,
screen_id,
"d_1",
{"type": "variable", "target_variable": "score", "data_operation": "incrementer", "data_value": "1"},
)
assert ok is True
screen = screens.get_screen(slug, screen_id)
rules = screens.resolve_screen_triggers(screen)
assert rules[0]["action"]["then"]["type"] == "variable"
def test_append_action_to_screen_trigger_returns_false_for_an_unknown_screen(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, _ = _create_jeu2d_game(client, tmp_game_slug_cleanup)
assert screens.append_action_to_screen_trigger(slug, 999999, "d_1", {"type": "dialogue"}) is False
def test_full_game_payload_exposes_screen_triggers(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(slug, screen_id, [{"trigger": "affichage", "action": {"type": "dialogue"}}])
payload = screens.full_game_payload(slug)
scene_screen = next(s for s in payload["screens"] if s["id"] == screen_id)
assert scene_screen["screen_triggers"] == [{"trigger": "affichage", "action": {"type": "dialogue"}}]
def test_screen_triggers_get_route_returns_the_saved_rules(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(slug, screen_id, [{"trigger": "affichage", "action": {"type": "dialogue"}}])
resp = client.get(f"/game/{slug}/screens/{screen_id}/triggers")
assert resp.status_code == 200
assert resp.get_json() == [{"trigger": "affichage", "action": {"type": "dialogue"}}]
def test_screen_triggers_post_route_appends_a_rule(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
resp = client.post(
f"/game/{slug}/screens/{screen_id}/triggers",
json={"rule": {"trigger": "affichage", "action": {"type": "dialogue"}}},
)
assert resp.status_code == 200
screen = screens.get_screen(slug, screen_id)
assert screens.resolve_screen_triggers(screen) == [{"trigger": "affichage", "action": {"type": "dialogue"}}]
def test_screen_trigger_delete_one_route_removes_only_the_targeted_rule(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(
slug,
screen_id,
[
{"trigger": "affichage", "action": {"type": "dialogue"}},
{"trigger": "affichage", "action": {"type": "son", "asset_url": "/assets/1/bip.mp3"}},
],
)
resp = client.delete(f"/game/{slug}/screens/{screen_id}/triggers/0")
assert resp.status_code == 200
screen = screens.get_screen(slug, screen_id)
rules = screens.resolve_screen_triggers(screen)
assert len(rules) == 1
assert rules[0]["action"]["type"] == "son"
def test_screen_trigger_delete_one_route_404s_for_an_out_of_range_index(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
resp = client.delete(f"/game/{slug}/screens/{screen_id}/triggers/0")
assert resp.status_code == 404
def test_screen_triggers_delete_route_clears_all_rules(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(slug, screen_id, [{"trigger": "affichage", "action": {"type": "dialogue"}}])
resp = client.delete(f"/game/{slug}/screens/{screen_id}/triggers")
assert resp.status_code == 200
screen = screens.get_screen(slug, screen_id)
assert screens.resolve_screen_triggers(screen) == []
def test_screen_triggers_get_route_backfills_and_persists_a_missing_leaf_id(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(
slug,
screen_id,
[
{
"trigger": "affichage",
"action": {
"type": "variable",
"target_variable": "score",
"data_operation": "incrementer",
"data_value": "1",
},
}
],
)
resp1 = client.get(f"/game/{slug}/screens/{screen_id}/triggers")
leaf_id = resp1.get_json()[0]["action"]["id"]
assert leaf_id
resp2 = client.get(f"/game/{slug}/screens/{screen_id}/triggers")
assert resp2.get_json()[0]["action"]["id"] == leaf_id # stable
append_resp = client.post(
f"/game/{slug}/screens/{screen_id}/triggers/append-action",
json={"after_id": leaf_id, "action": {"type": "dialogue", "dialogue": {"id": "d_1", "lines": []}}},
)
assert append_resp.status_code == 200
def test_screen_triggers_get_route_404s_for_an_unknown_screen(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, _ = _create_jeu2d_game(client, tmp_game_slug_cleanup)
resp = client.get(f"/game/{slug}/screens/999999/triggers")
assert resp.status_code == 404
def test_screen_trigger_dialogue_update_route_edits_the_matching_dialogue(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(
slug,
screen_id,
[
{
"trigger": "affichage",
"action": {"type": "dialogue", "dialogue": {"id": "d_1", "lines": []}},
}
],
)
resp = client.post(
f"/game/{slug}/screens/{screen_id}/triggers/dialogue",
json={"dialogue_id": "d_1", "lines": [{"speaker": "narrateur", "text": "Bienvenue !"}]},
)
assert resp.status_code == 200
screen = screens.get_screen(slug, screen_id)
rules = screens.resolve_screen_triggers(screen)
assert rules[0]["action"]["dialogue"]["lines"] == [
{"type": "dialogue", "speaker": "narrateur", "text": "Bienvenue !"}
]
def test_screen_trigger_remove_action_route_removes_the_whole_rule_when_it_is_the_only_leaf(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(
slug,
screen_id,
[
{
"trigger": "affichage",
"action": {"type": "dialogue", "dialogue": {"id": "d_1", "lines": []}},
}
],
)
resp = client.delete(f"/game/{slug}/screens/{screen_id}/triggers/action/d_1")
assert resp.status_code == 200
screen = screens.get_screen(slug, screen_id)
assert screens.resolve_screen_triggers(screen) == []
def test_screen_trigger_remove_action_route_404s_for_an_unknown_leaf_id(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(
slug,
screen_id,
[
{
"trigger": "affichage",
"action": {"type": "dialogue", "dialogue": {"id": "d_1", "lines": []}},
}
],
)
resp = client.delete(f"/game/{slug}/screens/{screen_id}/triggers/action/d_absent")
assert resp.status_code == 404
def test_screen_trigger_move_action_route_swaps_a_leaf_up_in_its_chain(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(
slug,
screen_id,
[
{
"trigger": "affichage",
"action": {
"type": "attendre",
"id": "a_1",
"data_value": "2",
"then": {"type": "dialogue", "dialogue": {"id": "d_1", "lines": []}},
},
}
],
)
resp = client.post(f"/game/{slug}/screens/{screen_id}/triggers/action/d_1/move", json={"direction": "up"})
assert resp.status_code == 200
screen = screens.get_screen(slug, screen_id)
action = screens.resolve_screen_triggers(screen)[0]["action"]
assert action["type"] == "dialogue"
assert action["then"]["type"] == "attendre"
def test_screen_trigger_move_action_route_400s_for_an_invalid_direction(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(
slug,
screen_id,
[
{
"trigger": "affichage",
"action": {"type": "dialogue", "dialogue": {"id": "d_1", "lines": []}},
}
],
)
resp = client.post(f"/game/{slug}/screens/{screen_id}/triggers/action/d_1/move", json={"direction": "sideways"})
assert resp.status_code == 400
def test_screen_trigger_append_action_route_attaches_a_leaf(
client: FlaskClient, tmp_game_slug_cleanup: Callable[[str], str]
) -> None:
slug, screen_id = _create_jeu2d_game(client, tmp_game_slug_cleanup)
screens.set_screen_triggers(
slug,
screen_id,
[
{
"trigger": "affichage",
"action": {"type": "dialogue", "dialogue": {"id": "d_1", "lines": []}},
}
],
)
resp = client.post(
f"/game/{slug}/screens/{screen_id}/triggers/append-action",
json={"after_id": "d_1", "action": {"type": "son", "asset_url": "/assets/1/bip.mp3"}},
)
assert resp.status_code == 200
screen = screens.get_screen(slug, screen_id)
rules = screens.resolve_screen_triggers(screen)
assert rules[0]["action"]["then"] == {"type": "son", "asset_url": "/assets/1/bip.mp3"}
Reference in New Issue View Git Blame Copy Permalink